Port soundmanager2 to Drupal 7

Fatal error: Call to undefined function content_notify() in /var/www/leniwiec/sites/all/modules/soundmanager2/sm2_plst_cck/sm2_plst_cck.install on line 12

Hi, thanks for your work !
i've just install sm2 module.. but i don't see it in cck displayfield ?? weird ^^
debug works ok
i also put this files "swftools_soundmanager2_adapted_26-10-2010" in sm2 module folder : is this the right place?
regards

during uninstall :

Fatal error: Call to undefined function content_notify() in /homez.380/onchange/www/sites/all/modules/sound/soundmanager2/sm2_plst_cck/sm2_plst_cck.install on line 40

so i can't uninstall it ^^;)

Hey,

Would you accept a patch for Drupal 7 that cleaned all the code as a first step (adhering to Drupal coding standards)? Also, have you thought of using hook_library() for adding in the JS, and would you be alright with getting rid of the JS global variables?

If so, I have a project that needs soundmanager2 and I'd love to clean this module up a bit.

Thanks,
Matt

Awesome! So here is a first patch toward cleaning up the module and finishing the implementation for Drupal 7. There are a number of changes in the patch, after applying the patch, run update.php to fix some variable names and also clear the cache and rebuild menus. Here is a list of changes so far:

• Clean up the code according to Drupal coding standards
• Remove references to audio module from the soundmanager2.module
• Cleanup description text everywhere to uniformly refer to SoundManager 2 as "SoundManager 2"
• Update hook_permissions() for Drupal 7
• Clean up hook_requirements() to fix a couple display bugs
• Cleaned up unsued or empty functions and old commented out code
• Replaced use of ereg_replace with preg_replace (ereg_replace is decremented in PHP 5.3)
• Added a hook_update_7200 function to update variable names to use underscores instead of dashes
• Replaced hook_init() with hook_library() and adding in libraries where appropriate. This is so that the JS/CSS is only added where it is needed
• Placed config setting under the Media category. They were not listed before when you went to admin/config.
• Use form_set_value() in form validate hook instead of changing $form_state directly
• Implement hook_field_formatter_info() and hook_field_formatter_view() to add the Page Player Formatter to File fields

At this point I have only worked on the main module and have only implemented a field formatter for the page player. I will finish the others over the coming week. You'll notice I put the field formatter definition in the main module. With file filed now in core, I didn't see the point in having those two hooks in their own module.

More to come, let me know if you have any questions, comments, concerns!

Thanks,
Matt

Hey,

Here is an updated patch, changes include:

• Got rid of some dsm() calls I left in the last patch.
• Deleted unused and unnecessary files and consolidated on a single module.
• Added support for UI 360 player and Inline Player in their default configurations
• Took the configuration JS files out of the libraries and instead added them via a theme function, making it easy for others to override the settings completely
• Added a formatter setting for the UI 360 player to allow users to select inline or playlist display.
• Don't show debug block if debug mode is off
• Add in styles to show the debug window like SoundManager does on their demo site

The changes are pretty huge, but I think you'll see that its a much improved, easily extendable and overridable way to add SoundManager 2 to your Drupal site.

Let me know any feedback.

Thanks,
Matt

I should mention that the patch in #11 replaces the patch in #10.

Not sure why that patch didn't work .. I did remove a bunch of files that are no longer needed / weren't used. With commit access now, I just merged my local feature branch with the 7.x-2.x branch and pushed it to the server. Update to the latest on the 7.x-2.x branch to see the changes.

By the way thanks for the commit access, look forward to working on the project!

Glad to see some movement here! I'll take a look at your work for D7 when I get a chance and file issues. Thanks for your work!

Wow! I just had a chance to test this tonight, and I couldn't break anything. It even worked fine for what I need with views. Great work!

Awesome! Thanks for the feedback. There are a couple issues I am aware of, and when I get a moment I'll describe them in more detail (haven't had a chance to work on this in awhile). In the meantime, I've made the dev snapshot available on the project page so that more people can take a look.

Thanks for that! I was going to ask, but you beat me to it!

Hi,

Thanks for this great module.

I think I have the same problem as ArchGalileu : I have a 200 pixels of useless space in the bottom of my web page, after the footer, and I can't get rid of it.

http://promotionlovebirds.ca/publicit%C3%A9-audio

Using Firebug, I found out that it is

subscribe

The extra space is being caused by "#sm2-container"'s embed, which has a height of 100% on it. This comes from the js of SM2 itself I think. You can easily set #sm2-container{display:none;} or something similar to take care of it.

This module shows the file name instead of the Node title. Will there be a fix for this?

"I think I have the same problem as ArchGalileu : I have a 200 pixels of useless space in the bottom of my web page, after the footer, and I can't get rid of it."

PLEASE - did you find a solution to this???????????????

Thank you very much for responding - it worked for me and saved a LOT more time.

THANKS!

My Drupal6 site is hosted in Hostmonter where there is a file upload limitation 2MB. So I transfer 2MB+ audio files through ftp, then use them through module Swftools.
Now I'm configuring Drupal7 to deal with audio using module Media and SoundManager2 .
As the link below describes, it allows to upload files through browser then play(show) them:
http://blog.musicvm.com/install-and-configure-media-module-music-drupal-7 : module Media+SoundManager2

How could I use files 2MB+ transferred through ftp?

Best regards.
Hugo

Are there any critical issues left that's blocking a beta version?
Running this on a clean d7 install and the latest soundmanager2 now with no major issues.

Solved the issue with the #sm2-container by adding a new css file with the following css, only targeting the injected container, which is placed one level deeper than the body tag in the dom. Using {display:none} mentioned in #25 caused sm2 to fail.

soundmanager2.css

body > #sm2-container {
  height: 0;
  overflow: hidden;
  visibility: hidden;
}

Then adding a new css file containing the code above when using the page player.

soundmanager2.module, line 33

+      'css' => array(
+        $sm2_module_path . '/soundmanager2.css' => array(),
+      ),

An essential feature that's lacking is id3 support. It's being worked on in the getid3 module: "Merge getID3 with FileField Meta in Drupal 7" (http://drupal.org/node/780848)

**edit**
sm2-container height issue applies to all player types, not just page player. updated this post to reflect this.

It doesn't seem to play nice with views 3 caching.

gridbitlabs, can you elaborate? maybe open a separate issue for it too.

To answer my own question above, I consider this a release blocker: styles added in ui360 multiple times

Just put this in
.css file the problem will be solved..

#sm2-container {
height: 0;
overflow: hidden;
visibility: hidden;
}

Just put this in theme .css file the problem will be solved..

#sm2-container {
height: 0;
overflow: hidden;
visibility: hidden;
}

Please see #1146172: Merge with audiofield module

@davebv - here's a first step to media module integration. this patch permits Soundmanager field handlers for Media type file fields and plays them as expected. hasn't been fully vetted but it's working for me so far. requires Media module.

patch in #38 committed to 7.x-2.x-dev

@andyhawks, this patch works as needs be, but I was wondering, whether there's a way of better integrating it with a private filesystem setup? As in the player works fine, allowing media elements to be played, however you can right click and simply download the file... Which is not ideal. Or is this more of an issue with the Soundmanager2 library itself?

Cheers

@tr33m4n - yeah switching to a private file setup doesn't work yet with this patch. There are known issues with Media and private files as listed on the Media project page and http://drupal.org/project/issues/media?text=private&status=All. I'll be looking into solutions for this more next week; it's a top priority for a site I'm working on too.

created beta release for 7.x-2.x.
moved comment #40 to #1877234: Private Files integration.