Posted by dooug on February 1, 2010 at 10:44pm
| Project: | E-Publish |
| Version: | 6.x-1.4 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | jerdiggity |
| Status: | closed (fixed) |
Issue Summary
I was reading the documentation at /admin/help/epublish and noticed that the right angle quotes were not being treated as html.
Example of expected link text:
"administer » topics » add vocabulary."
I'm seeing:"administer » topics » add vocubulary"
Comments
#1
I looked at the code and it was using the Drupal 5 version of the l() function. I updated these function calls where I found them. This module might need a more closer review, I noticed some other critical errors when I ran it through coder. I'll post those issues later if I can.
I have attached the patch. Please review and comment.
#2
Hi there. First off, just want to thank you for all the attention you've been giving to this module lately -- there's a lot that needs to be done to it (still) and at this point, I can't really use the I-just-recently-took-over-maintainership-of-this-module excuse anymore... (Although the term recently is such a broad term...) ;) But seriously, again, "Thanks!"
On top of that, the code for the documentation is probably one of the more prominent issues that needs to be addressed, for which I accept full responsibility -- if anyone needs to "blamed" feel free to point at me (you can even point at this issue for reference). It's one of the things I've started on but then........ yeah.
Anyway, I tested this patch & the only thing that needs correction is the actual paths themselves need to be updated (lots of "404 Not found" errors -- I assume the paths are still set at the old (5.x) version...???)
Very nice work, either way. :)
jeremy
#3
Committed to HEAD / 6.x-1.5 -- thanks again!
jeremy
#4
Automatically closed -- issue fixed for 2 weeks with no activity.