Closed (fixed)
Project:
Bartik
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Feb 2010 at 14:35 UTC
Updated:
26 Mar 2010 at 14:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jensimmons commentedHmmm, this is interesting. I don't usually use reset stylesheets, but did for Bartik, in part because reset.css-es are being used in other places in Drupal core. I started out with the full-length Eric Meyer reset, but over time stripped most of it out. Maybe now I should just move what's left into styles.css and have there be one less css file.
I also don't think this is a very big deal — it does work fine as is.
What do other people think?
Comment #2
Anonymous (not verified) commentedThere seems to be an 'argument' for using a reset css as best practise from what I have read online.
eg http://sixrevisions.com/css/css-tips/css-tip-1-resetting-your-styles-wit...
I would however have this as the beginning of the main style sheet instead of separately.
Comment #3
dodorama commentedI'd say that the main argument of the article you linked (avoid browser inconsistencies) is not always valid. As pointed by jensimmons in this comment while talking about rounded corner support on IE, websites don't need to look the same in every browser. Moreover I'm pretty sure that the most annoying differences (like the margins on paragraphs) are styled, anyway, in the main stylesheet resulting in duplicated code. I believe that some (soft) reset styles (if needed) can be moved inside the main stylesheet as jensimmons suggested.
Comment #4
willmoy commentedMoving to bartik project.
Comment #5
willmoy commentedComment #6
emmajane commentedI've combined the reset styles and the main style sheet into a single file. Patch attached.
Comment #7
emmajane commentedTake two on attaching the patch....
Comment #8
jacineCommitted! :D
Also removed the stylesheet entry from the .info file.
Comment #9
emmajane commentedThanks for removing it from the .info file too. Awesome! :)