Is it really necessary to ship with a reset.css? It's one more file to maintain and more code to load.
Here's an interesting reading on the disadvantages of using them.
http://meiert.com/en/blog/20080419/reset-style-sheets-are-bad/

CommentFileSizeAuthor
#7 combine-styles-reset.patch1.08 KBemmajane

Comments

jensimmons’s picture

Hmmm, this is interesting. I don't usually use reset stylesheets, but did for Bartik, in part because reset.css-es are being used in other places in Drupal core. I started out with the full-length Eric Meyer reset, but over time stripped most of it out. Maybe now I should just move what's left into styles.css and have there be one less css file.

I also don't think this is a very big deal — it does work fine as is.

What do other people think?

Anonymous’s picture

There seems to be an 'argument' for using a reset css as best practise from what I have read online.

eg http://sixrevisions.com/css/css-tips/css-tip-1-resetting-your-styles-wit...

I would however have this as the beginning of the main style sheet instead of separately.

dodorama’s picture

I'd say that the main argument of the article you linked (avoid browser inconsistencies) is not always valid. As pointed by jensimmons in this comment while talking about rounded corner support on IE, websites don't need to look the same in every browser. Moreover I'm pretty sure that the most annoying differences (like the margins on paragraphs) are styled, anyway, in the main stylesheet resulting in duplicated code. I believe that some (soft) reset styles (if needed) can be moved inside the main stylesheet as jensimmons suggested.

willmoy’s picture

Project: Drupal core » Bartik
Version: 7.x-dev »
Component: other » Code

Moving to bartik project.

willmoy’s picture

Issue tags: -D7 theme, -Bartik
emmajane’s picture

Version: » 7.x-1.x-dev
Status: Active » Needs review

I've combined the reset styles and the main style sheet into a single file. Patch attached.

emmajane’s picture

StatusFileSize
new1.08 KB

Take two on attaching the patch....

jacine’s picture

Status: Needs review » Fixed

Committed! :D

Also removed the stylesheet entry from the .info file.

emmajane’s picture

Thanks for removing it from the .info file too. Awesome! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.