I noticed a few coding standards issues with spacing and conditional formatting, so I ran coder_format.php and generated this patch. A visual scan of the patch shows it's stylistic and after applying, basic operations (creating a selection poll, voting, canceling a vote) continue to work as expected.

CommentFileSizeAuthor
#6 decisions_code_format_b.patch98.28 KBezra-g
#5 decisions_code_format_a.patch99.11 KBezra-g
decisions_code_standards.patch101.81 KBezra-g

Comments

anarcat’s picture

anarcat commented
Status: Needs review » Needs work

not to be nitpicking here: coder_format is cool, but there are some things that don't really work out for me. a lot of lines are added in irrelevant places, like this:

@@ -45,6 +45,7 @@
   }
   if ($op == 'update') {
     /* you can update it if you can create it, provided it is your own... */
+
     if (user_access('create decisions', $account) && ($account->uid == $node->uid)) {
       return TRUE;
     }

I also don't see why every file should have an extra newline at the end, but if it's the standard, I won't argue.

I am otherwise ready to commit this patch provided the needless newlines are removed.

ezra-g’s picture

ezra-g commented
Status: Needs work » Needs review

Here's a re-roll that removes the extraneous newlines, leaving in place the ones at the end of each file per the coding standards>, "All text files should end in a single newline (\n). This avoids the verbose "\ No newline at end of file" patch warning and makes patches easier to read since it's clearer what is being changed when lines are added to the end of a file."

Thanks :)

ezra-g’s picture

ezra-g commented

[deleted dupe comment] - Sorry, I got a 503 upon submission ;)

ezra-g’s picture

ezra-g commented

And here's the patch, hopefully 503 free...

ezra-g’s picture

ezra-g commented
StatusFileSize
new decisions_code_format_a.patch99.11 KB

And here's the patch, hopefully 503 free...

ezra-g’s picture

ezra-g commented
StatusFileSize
new decisions_code_format_b.patch98.28 KB

If you don't hate my dupes by now, here is the correct patch. Sorry about that :).

anarcat’s picture

anarcat commented
Assigned: Unassigned » anarcat

checking this this afternoon, i'd love to get that cleanup in.

anarcat’s picture

anarcat commented
Status: Needs review » Fixed

I committed your patch with a few changes in hairy boolean comparisons that were hurting my brain. I also removed those idiotic "end if" things.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.