Closed (fixed)
Project:
PAD File
Version:
6.x-1.x-dev
Component:
PAD File Module
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
3 Feb 2010 at 02:52 UTC
Updated:
16 Mar 2010 at 09:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
AlexisWilke commentedvv75,
Can you share you PAD file here?
It looks like one of the fields is not set as expected...
Thank you.
Alexis
Comment #2
vv7 commentedwhy should i share my pad, if i don't even come to involving it in any way?
i just installed the module, then pressed "PAD Files" in the Administer section.
Comment #3
AlexisWilke commentedvv75,
Ah! I see. This is a parsing error. You must have an "older" version of PHP.
I'm attaching a patch. Let me know if that solves the problem. The 1.x-dev will be updated within 12h.
Thank you.
Alexis
Comment #4
vv7 commentedthe patch helped, thanks.
now i get "Fatal error: Cannot instantiate non-existent class: domdocument in .../padfile/padfile.admin.inc on line 1374"
while trying to import my existing pad file.
looks like it requires some DOM-related php library which my hoster doesn't have?
and which is also not documented in the requirements for the module?
discuss it here, or close this issue and open another one?
Comment #5
AlexisWilke commentedvv75,
Yes. You would need to have DOMDocument. It is available since PHP 5.x and it sounds like you're using PHP 4.x! Your hosting company should at least offer 5.x!!!
http://us3.php.net/manual/en/intro.dom.php
Note that for the output, I don't use the DOM, I simply generate the XML in a string. That goes really fast and does not generate a dependency. In other words, you should be able to create PADFiles that you can serve, but not import them...
Unless you want to consider switching providers... we offer Drupal hosting at my company and I can assure you that I used the Import feature several times.
Thank you.
Alexis
Comment #6
vv7 commentedour hoster said something about php5, but we didn't listen very attentively. :)
we had other priorities at that time.
i mark this issue as fixed and you may close it.
thanks again.
Comment #8
vv7 commentedplease include this patch in the trunk branch too.
Comment #9
AlexisWilke commentedYes. It is in 1.x-dev right now. I will wait a couple days before moving it to 1.4
Thank you.
Alexis
Comment #10
AlexisWilke commentedOkay, the fix is part of 1.4
Yet again, if you don't have the DOM, it won't work. I do not know whether it is possible to add an implementation of the DOM that works with PHP 4.x
Thank you.
Alexis
Comment #11
vv7 commentedlet that be not your headache.
just mention somewhere in the readme that import won't work without DOM.