For the Views 3 export to work the handler must define all of its options in definition() function. The Slide show style handler fails this in several places, the big one being the 'mode' option.

Attached is a patch to bring it up to snuff.

CommentFileSizeAuthor
#8 704096-option_definition-1.patch18.56 KBredndahead
#1 views_slideshow_704096-1.patch17.71 KBScott Reynolds

Comments

Scott Reynolds’s picture

Scott Reynolds commented
Title: Views 3 Export » Views 3 requires proper option_defintion()
StatusFileSize
new views_slideshow_704096-1.patch17.71 KB

here is the patch. its pretty invasive.

Scott Reynolds’s picture

Scott Reynolds commented

there is one small code style error. The #default_value for breakout_fields should have a space after the =>

jrabeemer’s picture

jrabeemer commented

Slideshow now appears for me in the style list.

redndahead’s picture

redndahead commented
Status: Needs review » Postponed (maintainer needs more info)

Is this views 3 only? or is everything in this patch ok to use with views 2?

jrabeemer’s picture

jrabeemer commented
Status: Postponed (maintainer needs more info) » Needs review

This is Views 3. Please review the patch with Views 2.

Scott Reynolds’s picture

Scott Reynolds commented

No its not Views3 only, its Views2 as well. It just your option_definition was incomplete and it didn't list all the options. This is a problem for the condensed Views3 output only.

It will not negatively affect Views2 at all.

redndahead’s picture

redndahead commented
Priority: Normal » Critical

marking as critical to look at before release

redndahead’s picture

redndahead commented
StatusFileSize
new 704096-option_definition-1.patch18.56 KB

Here's a re-roll with the styling fixed. I'll look at the patch in a sec

redndahead’s picture

redndahead commented
Status: Needs review » Fixed

After looking at this I like this much better. This is a great patch thanks. It has been committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.