Add a link to the CVS RSS feeds.

Bèr Kessels - June 23, 2006 - 08:48
Project:Project
Version:x.y.z
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:duplicate
Description

Often requested, simple to implement: An easy and quick way to track a project in RSS. Patch adds that.

After the patch the line goes like
» View CVS messages (RSS).

AttachmentSize
addCVS_RSSlink.patch.txt641 bytes

#1

halkeye - June 23, 2006 - 08:57
Status:patch (code needs review)» patch (code needs work)

Didn't work for me

your $query has a "?" in it., taking out the ?, everything works fine.

#2

Bèr Kessels - June 23, 2006 - 13:33

removed the ?

AttachmentSize
addCVS_RSSlink.patch_0.txt640 bytes

#3

halkeye - June 23, 2006 - 16:42
Status:patch (code needs work)» patch (code needs review)

seriously man, you need to actually test this

replaced the "." with "," before the query.

AttachmentSize
drupal.addCVS_RSSLink.patch_1.txt673 bytes

#4

dww - June 28, 2006 - 19:03

latest patch seems reasonable upon simple inspection. however, i'm currently on vacation until july 16th, with no good means to actually test anything like this. i refuse to commit changes to the project module that i can't test, so this will either have to wait, or nedjo/dries will have to test and commit it.

furthermore, there's active effort towards making the project module more RCS-independent (http://drupal.org/node/70125) and this particular patch is a step away from that goal. this is just a minor addition to an existing problem, so i'm not going to refuse it on those grounds. however, in general, i'd prefer if new patches that touch CVS stuff do it in a way that moves CVS-specific functionality out of project and into cvslog, where it belongs. for example, adding this link could be done via hook_nodeapi() in cvs.module...

thanks,
-derek

#5

aclight - April 13, 2008 - 17:32
Status:patch (code needs review)» duplicate

This is a duplicate of #31994: Add a link to CVS RSS feeds from project node page.

 
 

Drupal is a registered trademark of Dries Buytaert.