PHP 5.3.1 Support

Posted by pumpkinkid on February 5, 2010 at 5:23am

7 followers

Issue Summary

I know what you are thinking Rik... but it's not what you think... lol

I am moving my personal server to a VPS server using cloud hosting and I thought it would be neat to try PHP 5.3.1 before pulling the switch... When I was making sure my setup was decent, I noticed that when I went to edit the nodes, it gave me the access denied message. Narrowed it down to Revisioning since disabling it brought back the edit options... Reverted back to PHP 5.2.12 and now everything works as expected.

I just thought I'd mention this since I ran across it, but you might have even know about this and just not support 5.3.1 yet... Either way, just wanted to see if this information could be useful to you, however, it may just be the buggy Zend support in 5.3.1 that may have caused this.

Comments

#1

Posted by dooug on February 22, 2010 at 9:29pm

Status:

active

» needs work

PHP 5.3.0
Drupal 6.15
Revisioning 6.x-3.4

When viewing the revisions tab:

warning: Parameter 2 to _revisioning_view_edit_access_callback() expected to be a reference, value given in XXXXXX/includes/menu.inc on line 452.

The following patch cleared the issue.

Attachment	Size
revisioning_705380_php53_warning_1.patch	688 bytes

#2

Posted by RdeBoer on February 24, 2010 at 2:31am

Category:	feature request	» task
Assigned to:	Anonymous	» RdeBoer

Thanks for the patch doug!
While it may get rid of the error, it seems to me that it also may get rid of some of the functionality, namely the defaulting to view/edit the latest revision when a view/edit link is clicked. This functionality required the node->load_op
I need to implement a better solution that doesn't rely on the &ref.

#3

Posted by rkodrupal on February 27, 2010 at 3:58pm

watching

#4

Posted by Moosa on March 3, 2010 at 2:06am

hello,
can you provide me guys with the easiest way to apply this patch ?

#5

Posted by RdeBoer on March 3, 2010 at 5:39am

Hey Moosa,
Because it's only 1 character that you have to remove (the ampersand &), the quickest way is to open the file sites/all/modules/revisioning/revisioning.module in an editor and change line 378

function _revisioning_view_edit_access_callback($revision_op, &$node) {

function _revisioning_view_edit_access_callback($revision_op, $node) {

Good luck!

#6

Posted by dooug on March 3, 2010 at 6:33pm

Moosa:
Checkout the Drupal Handbook page to apply patches.

#7

Posted by Moosa on March 4, 2010 at 11:40pm

thnx RdeBoer, the quick solution solved it, no need for the patch :)

#8

Posted by Moosa on March 5, 2010 at 12:27am

it works fine now, the only place i get this error now is when i click publish on some pending review

warning: Parameter 2 to revisioning_revisionapi() expected to be a reference, value given in C:\xampp\htdocs\drupal\includes\module.inc on line 483.
warning: Parameter 2 to revisioning_revisionapi() expected to be a reference, value given in C:\xampp\htdocs\drupal\includes\module.inc on line 483.

#9

Posted by RdeBoer on March 5, 2010 at 2:58am

Thanks for reporting Moosa. I'll have to fix that instance too.

#10

Posted by losman on March 5, 2010 at 10:45pm

Like Moosa, I get thesame error after I publish and no email goes out either.

warning: Parameter 2 to revisioning_revisionapi() expected to be a reference, value given in E:\wamp\www\includes\module.inc on line 483.
warning: Parameter 2 to revisioning_revisionapi() expected to be a reference, value given in E:\wamp\www\includes\module.inc on line 483.

Thanks

Losman