Hi,

I'm using a modified version of Newswire 3.2, but I think this also happens in 4.1

If you try to build a multilingual site and enable Menu Translation module (part of i18n package) then the suckerfish menu and all it's theming collapses.

Would you be so kind as to say what the problem is?

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Postponed (maintainer needs more info)

Need more information - what are you doing here, are you actually translating a menu? Do you have a link to the site? What do you mean by "all it's theming collapses". Needs details.

drupalina’s picture

drupalina commented

Just simply install a simple website with Newswire 3.2 and with some random drop-down hierarchical menus in Suckerfish region and then enable the Menu Translation module. And see what happens to the Suckerfish menus - they stop dropping down. They just become Primary links as usual. The same problem also happens in 4.1.

I'm just trying to find the problematic bit, because my theme is a heavily modified version of 3.2 and reconstructing this theme anew in 4.1 would not be productive, especially since this problem exists also in 4.1

I have found a temporary workaround: I don't enable Menu Translation, but instead I use Block Translation module. Then create 3 separate menus (1 for each language), which also generates 3 blocks for each menu. I then assign a language to each of those menu blocks and put all 3 of them into the Suckerfish region. The drop-down effect works in 4.1 and almost works in 3.2, but in 3.2 all the rest of the javascript effects on a page (draggable blocks, views carousel etc) stop working. Plus, without the Menu Translation turned on, the Secondary Menu (which is just a bunch of Taxonomy Category names) and all other custom menus in other regions remain untranslated. I don't think that this method is a clean and durable solution. So a way must be found to make Suckerfish retain its functionality while the Menu Translation module is enabled.

Jeff Burnz’s picture

Jeff Burnz commented
Version: 6.x-4.1 » 6.x-3.2
Component: Code » User interface
Status: Needs review » Active

I think this needs to be moved to the i18n queue - its not a problem with the theme but with how i18n handles primary links. I doubled tested with Zen classic theme and the primary links remain active even when they are toggled OFF in theme settings. In my case I have Swedish and English and the primary links for Swedish show even when I toggle the primary links off in the theme settings - thats not right.

So the trouble starts with Newswire because the primary_links must be not set for the suckerfish region to show - but for some reason they always are when i18n menu translations are involved (even when toggled off). I haven't tested every variation but enough to know something is not right here (afaict).

I was able to fix this in Newswire by reversion the logic for $suckerfish and $primary_links, eg in page tpl use this instead:

      <?php if ($suckerfish || $primary_links): ?>
        <div id="<?php print $suckerfish ? 'suckerfish' : 'primary-menu' ; ?>" class="width-45-890">
          <?php 
           if ($suckerfish) { print $suckerfish; }
           elseif ($primary_links) { print theme('links', $primary_links, array('class' => 'primary-links clearfix')); } 
          ?>
        </div> <!-- /primary/suckerfish -->
      <?php endif; ?>

Just to be clear I used two menus - one for English and one for Swedish and placed them both in the suckerfish region. With the change above and this setup with the menu blocks everything works as you would expect it to.

The other option is to just make sure there are no primary links - that the primary menu is empty or all links in the menu are disabled - its not enough to just toggle the primary menu off in the theme settings.

Needs to be addressed with i18n Menu Translation module - like I say I can work around this in Newswire but for other themes this will be a problem.

Jeff Burnz’s picture

Jeff Burnz commented
Version: 6.x-3.2 » 6.x-4.1
Component: User interface » Code
Status: Postponed (maintainer needs more info) » Needs review

Switching to latest version, I cant add a fix to an earlier minor version.

johan2’s picture

johan2 commented

Sorry,
I removed and posted a new issue.

Jeff Burnz’s picture

Jeff Burnz commented
Version: 6.x-3.2 » 6.x-4.1
Component: User interface » Code
Status: Active » Needs review

@johan2 - hijacking threads is bad form.