Posted by willmoy on February 13, 2010 at 2:23pm
8 followers
| Project: | Bartik |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Quoting joachim on the main thread:
Only one sidebar now? How easy is it to modify the theme to put it on the left instead of the right? If we're aiming to be easily modifiable, changing sidebars from side to side is something people will want to do.
http://drupal.org/node/683026#comment-2542558
I'm calling this a bug because I think otherwise Bartik's too prescriptive to be the default theme.
Comments
#1
I've committed a fix to this on github.
#2
For ease of reference, comment on the main thread:
http://drupal.org/node/683026#comment-2597716
and the fix is here:
http://github.com/joachim-n/Bartik/commit/13180dbfe12bda2f6aa3396a22bfb6...
#3
Now we have a bartik project, moving there. Marking as critical because I assume it blocks bartik in core.
#4
Marking as needs review because joachim has code for this.
#5
I tried to recreate this as a patch. Can't read patches well so got confused with the part in layout.css, is there a link on that github page that exports the fix as a patch?
Work in progress patch, needs review for bot, then needs work to add the changes in layout.css
#6
Here's a proper patch of the whole change.
Changing issue name too.
As I remarked in the main Bartik issue, there remains a problem with the full widths across the page not adding up which my patch does not address as I'm not sure what jensimmons' intentions are here.
#7
The patch is fantastic. Screenshots attached #1,2,3.
HOWEVER, when the "display content in hidden regions" is turned on, the layout fails miserably. See attached screenshots #4,5.
If this doesn't matter because people should just turn that bit off, please mark the patch "reviewed and tested by the community" (which means Jen should roll it into the main theme).
If this DOES matter (which it probably does?) then the patch will need to be updated to fix the Lorem ipsum block.
#8
We will be removing the dummy content as per webchick's request — so we don't need to fix the layout with that content.
#9
This should fix the git prefix issue
#10
I'm still getting errors for this patch.
patching file bartik.info
Hunk #1 succeeded at 18 (offset -1 lines).
patching file css/layout.css
Hunk #2 FAILED at 113.
1 out of 2 hunks FAILED -- saving rejects to file css/layout.css.rej
patching file page.tpl.php
I'm going to try and roll it from scratch.
#11
Rerolled against HEAD
#12
#13
That chx reroll works great. Thanks everyone.
As soon as I figure out how to properly commit a patch, I will.
#14
Committed!
(my first cvs commit)(ever)
#15
Automatically closed -- issue fixed for 2 weeks with no activity.