OK, the objective is to allow more people to moderate nodes without giving them the keys to the kingdom. This has come out of Proposal: How to get more people involved with documentation.

At the time of writing there are 180 edits in the moderation queue. So we need to start finding a way to take the burden off existing site admins.

I've started by taking pwolanin's patch at #18 and merging it with latest CVS node.module and pushing out this patch. I have not tested it yet. I plan to be testing this with an upcoming project with book module.

CommentFileSizeAuthor
moderate_nodes.patch3.7 KBsime

Comments

pwolanin’s picture

pwolanin commented

Ok, I'd be happy to work on this a little more either as a hack for Drupal.org, or as a potential new feature.

I have not been following closely any discussions regarding possible reorganization of the permissioning system in 4.8- if there's somewthing I need to know, please point me in the right direction.

sime’s picture

sime
any/any
Location Melbourne
commented

From what I can tell, we need to focus on it being a new feature, since drupal.org is fairly stock. If there was going to be a custom fix to drupal.org (which is possible but unlikely), the feature will need to be present in 4.8 for when Drupal.org is upgraded.

I simply don't know whether this issue should tie in with Save revision as draft.

pwolanin’s picture

pwolanin commented

Looking at the code a little more, it seems like it might make sense to try to quickly roll this functionality into a separate module that could be used now, rather than chasing the HEAD version of node.module. Would such a module potentially be used on Drupal.org?

dfserra’s picture

dfserra commented

Nodes moderation is very interesting.

I would like a little different.

My necessities are:

Some people can publish nodes without moderation, and others with moderation.;
There are nodes moderators;
The configurations to be able to be different for nodetype;
Everything this without the need of the permission “administer nodes”.

For such I think that such as in the comments, would be enough, to add two new permissions for each nodetype:
Create nodes with approval;
Node moderator.

I think that this functionality is very important.

pwolanin’s picture

pwolanin commented
Status: Active » Needs work

Ok, trying to learn to use CVS properly. I added a draft module hacked from the body of node.module at:

http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/pwolanin/cont...

I haven't actually tested it yet, but any intial review welcome.

pwolanin’s picture

pwolanin commented

code seems to be working reasonably now, and submitted as a project:

http://drupal.org/project/content_moderator

sime’s picture

sime
any/any
Location Melbourne
commented

We'll need some drupal admins to review this, so to make that process smoother, can you:

- put linefeeds in README.txt
- change the description of your module as "hacked out of node.module"

I am also wondering, how does this module work with existing access modules? I am not an expert in this area, but I understand that something like na_arbitrator is required to help multiple "node access" modules work together. Does this module fall into that category?

pwolanin’s picture

pwolanin commented

I would be happy to revise the description if that's too colorful - take a look at the version now.

The only node-access interfacing is done by calling sql_rewrite when generating lists of nodes, and by calling node_access('update', $node) when determining whether to show an 'edit' link. Since these are core methods, I'd think it should be agnostic as far as any actual access control modules in use.

sime’s picture

sime
any/any
Location Melbourne
commented
Status: Needs work » Needs review

Great, I'll try and test this soon.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work
dfserra’s picture

dfserra commented

pwolanin

The module content_moderator is an advance. But it doesn’t satisfy my needs in #4.

I think this feature is important include in core.

pwolanin’s picture

pwolanin commented

From my understanding of what's happening for 4.8, all use of the moderation flag will be removed from core.
So, you're welcome to use/change the module I contributed as far as it suits you needs, but i don't think that a "moderate" permission looks likely to make it into core for 4.8 unless it affects the "status" flag instead of the "moderate" flag.

sepeck’s picture

sepeck commented

just confirmend with drumm that the bit this relies on will not be in 4.8.

sime’s picture

sime
any/any
Location Melbourne
commented

Thanks Steven.
I had my suspicion that might be the case.

pwolanin’s picture

pwolanin commented

I think the moderate bit itself will still be in the DB, but no core code will use it:

http://drupal.org/node/72343

Please correct me if I'm wrong, since I think that removing the bit from the schema would be a mistake.

pwolanin’s picture

pwolanin commented
Version: x.y.z » 5.x-dev
Status: Needs work » Closed (fixed)