This patch allows users to exclude certain node types from RSS feeds in Admin > Settings > RSS feed settings.

Open to suggestions. Might help here http://drupal.org/node/28337.

CommentFileSizeAuthor
#2 rss_0.patch2.36 KBnickl
rss.patch2.18 KBRobRoy

Comments

dries’s picture

dries commented
Status: Needs review » Needs work

What is the use case for this feature? Why would you want to exclude certain node types? Examples?

The way to fix this is to use node-level permissions (which has a performance cost). The proposed patchbreaks other settings. If I configure my RSS feed to show 10 items, and if 9 out of 10 items are of a node type that is to be excluded, there will only be 1 item in the RSS feed. To fix this, we need to exclude the nodes at the SQL level so that 10 correct nodes are returned ...

nickl’s picture

nickl commented
Status: Needs work » Needs review
StatusFileSize
new rss_0.patch2.36 KB

Patch Bingo!
Could be an usability enhancement?
Rerolled to fresh head.
Building proper select options from node_type object array.
Filtering excluded types at the sql level to return feed_default_items number of nodes excluding feed_excluded_node_types.

boris mann’s picture

boris mann commented

Yeah, I'd like to see a use case for this as well that applies to core. My instinct is to say "use Views".

RobRoy’s picture

RobRoy commented
Status: Needs review » Fixed

Now that I know a bit more about Views, marking this fixed. There is a patch at http://drupal.org/node/62007 regarding adding an 'access RSS feed' perm, let's work on that.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)