Subscriptions to project issues for new projects added after subscription settings have been saved

Here's a start - add some sanity to the page callbacks.

ok, no project/issues//subscribe path since that clashes with a project...

Let's move discussion (and any further patches) about the menu callback sanity over to http://drupal.org/node/163599.
Until that's committed, we'll call this postponed.
Thanks!
-Derek

http://drupal.org/node/163599 is now committed to HEAD, so this is back to active.

patch no longer applies.

couple of things from the code review:

• really have to get rid of the $GLOBALS['user'] usages
• project_issue_page_myissues -> project_issue_page_my_issues
• looks like we bagged the 'subscribe' path, and the 'Subscribe' button from our processing logic -- have we accounted for that changed, because it doesn't look like it.

cleanup for the menu callbacks, and some additional cleanup/bugfixes for the subscribe form. the subscription status should properly default to 'None' if there's no entry in the database, and i've added links to the project pages -- seems convenient to have if you want to check out a project before you decide to subscribe.

tested the subscription form extensively, and it appears to be working well. tested all the other paths briefly and they seem good as well -- all testing on postgres.

as far as the original bug report, i don't see a truly clean way to do this -- there's no way to tell currently that a user did, in fact, select any of the global options. we *could* do a slight hack, and, say, create a special nid of -1 for users who select a global option, then check for that and load all projects if it's found.

even if we did that, the upgrade path would be a nightmare, because of the aforementioned information deficiency.

I'm confused by this patch. http://drupal.org/node/163599 ended up being a failure, and was rolled back. Most of these menu callbacks should just be replaced by project_views.inc and some default views. I don't really see what we gain by reorganizing them if we're just going to rip them all out in the near future.

Then, there's the problem that improvements to the subscription form (unrelated to menu callback sanity, IMHO) is mixed in to this patch, making it harder to ensure we're just fixing the subscribe problems.

Also, please see http://drupal.org/node/161850 for a broader perspective on this bug and possible solutions...

Setting to needs work since I'd rather this patch *just* made fixes to the subscribe form and behavior. I'm feeling bitten by attempts to reform the menu callback insanity -- I think we need a revolution, instead of incremental change. ;)

you're confused by the patch b/c i was confused what the issue is here. i'd much rather close this extremely confusing thread and open two separate new issues (one for the issue described in the title, one for my subscriptions form fix. i'll open the subscription for issue right now...

closing, please refer to http://drupal.org/node/177318 -- which basically restarts the issues w/o all the posting confusion.