Hi,

I'm doing some testing of your module and I noticed that if you don't define any extensions in the widget settings, the file browser wont allow any files to be selected, whereas the correct behavior is supposed to be any extensions are allowed when no extensions are defined.

CommentFileSizeAuthor
#3 swfupload-717578-1.patch976 bytesskilip

Comments

Countzero’s picture

Agree. Same problem here, and it's really annoying !

Countzero’s picture

As a workaround, you can comment out line 59 of swfupload.admin.inc

'file_validate_extensions' => array($widget->file_extensions),

or taylor it to suit your needs as of http://api.drupal.org/api/function/file_validate_extensions/6 .

skilip’s picture

Status: Active » Needs work
StatusFileSize
new976 bytes

This patch should fix this

skilip’s picture

Status: Needs work » Needs review

Oops!

eugenmayer’s picture

For chrismas Eugen wishes a 2 line statement + docs for this :) I dont get what it is about. Thanks! :)

skilip’s picture

LOL

skilip’s picture

Status: Needs review » Patch (to be ported)
steven jones’s picture

Where does this patch need porting to?

eugenmayer’s picture

Steven that status means, that the maintainer, skilip, is going to merge this patch into the code. Or in other words, patch accepted :)

steven jones’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

That'll be RTBC then...

eugenmayer’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

Steve please dont change the status, thats the maintainers job :)

path is here: http://drupal.org/node/717578#comment-2930056

steven jones’s picture

From http://drupal.org/node/156119:

Patch (to be ported)
The patch has been successfully committed to a branch of the project, and still needs to be committed to another, but the current patch doesn't apply to the target branch and needs to be modified in order to do so.

Its confusing for the community if module maintainers make up their own ideas around what the statuses mean.

Is this patch in the code then, and just needs porting over to another version?

eugenmayer’s picture

No this patch _needs_ to be applied now. If this happened, its "fixed"

steven jones’s picture

Does the patch need to be ported because you are using git to manage this project? And thus the patch doesn't apply cleanly to the codebase in CVS. If so, is the git repo public?

steven jones’s picture

eugenmayer’s picture

Steven skilip and me are working on the new release there, right. Its not "my fork" or something, just a base were we work together and i think skilip adminitted to released from there ( so after its finished we commit the release version into d.o CVS and release ).

But i think he should answer by himself :)

skilip’s picture

Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Countzero’s picture

I had the same issue again after upgrading to beta8, fixed as in http://drupal.org/node/717578#comment-2929976 above.

I'm not reoping, but I think it's worth a look.

Thanks for the module anyway.