Ranking.module duplicates hooks such in ranking_access, ranking_form, and ranking_perm, all of which call the corresponding decisions module hooks. These ranking hook implementations should be removed.

Comments

anarcat’s picture

anarcat commented

The idea here dates back from the old days where decisions was a monolithic module. Since ranking and selection are now modules which can be turned off and implement their own content types, I figured those hooks were necessary for proper operation of the module, but I can be mistaken. The idea is that specific modes could override the default implementations...

I am also less and less certain of the approach of making ballot modes actual modules: maybe modularity should be implemented at the decision algorithm level, which could be exported to other modules too. But that's another question, discussed in #532758: 2.0 - refactor algorithms into modules...

ezra-g’s picture

ezra-g commented
Status: Active » Fixed

Good to know to the background here :). Since decisions must be installed for ranking and selection to function, these hooks are duplicates. They are now removed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.