Closed (fixed)
Project:
Feeds
Version:
6.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Feb 2010 at 12:01 UTC
Updated:
16 Mar 2010 at 15:00 UTC
Jump to comment: Most recent file
If the collection is set to try PuSH but collected data isn't (valid) XML SimpleXMLElement($data) throws an exception which isn't caught.
PHP Fatal error: Uncaught exception 'Exception' with message 'String could not be parsed as XML' in /var/www/html/drupal/contrib-6/feeds/libraries/PuSHSubscriber.inc:79\nStack trace:\n#0 /var/www/html/drupal/contrib-6/feeds/libraries/PuSHSubscriber.inc(79)...
I've just wrapped it in a try/catch without really doing anything with the exception (basic patch in a sec)... not sure if it should do more.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 724184-2_catch_exceptions.patch | 1.65 KB | alex_b |
| #1 | feeds-pubsubhubbub-724184-1.patch | 1.52 KB | ekes |
Comments
Comment #1
ekes commentedComment #2
alex_b commentedThank you, ekes. This is looking good.
Comment #3
alex_b commentedCommitted. Thank you. Attached the slightly modified patch that got committed.
http://drupal.org/cvs?commit=336042
http://github.com/lxbarth/PuSHSubscriber/commit/53602944240743599cde3b54...