t() overhaul and some other small changes

Looks good, but I prefer to keep two spaces between sentences for grammatical reasons.

Depends. Most style guides I've seen recommend it, but it's not necessary. My preference is to use two simply because it better deliniates the sentence boundaries, but I suppose its more a matter of personal preference than anything.

I like (and need) those changes. However, I have noticed something suspicious in forward.module, near line 343. With the patch, the following:

    $form['message']['forward_footer'] = array(
      '#type' => 'hidden',
      '#value' => variable_get('forward_footer', ''),
    );
    $form['message'][] = array(
      '#type' => 'submit',
      '#value' => t('Send e-mail'),
    );

... becomes:

    $form['message']['forward_footer'] = array(
      '#type' => 'hidden',
      '#type' => 'submit',
      '#value' => t('Send e-mail'),
    );

Any explanation? Thanks.

It's this part of the patch:

@@ -341,15 +341,12 @@ function forward_form() {
     );
     $form['message']['forward_footer'] = array(
       '#type' => 'hidden',
-      '#value' => variable_get('forward_footer', ''),
-    );
-    $form['message'][] = array(
       '#type' => 'submit',
-      '#value' => t('Send Message'),
+      '#value' => t('Send e-mail'),
     );
 
     $form['#method'] = 'post';
-    $output = drupal_get_form('forward_form', $form);
+    $output .= drupal_get_form('forward_form', $form);
   }
   return $output;
 }

That should be changed to this:

@@ -341,15 +341,12 @@ function forward_form() {
     );
     $form['message'][] = array(
       '#type' => 'submit',
-      '#value' => t('Send Message'),
+      '#value' => t('Send e-mail'),
     );
 
     $form['#method'] = 'post';
-    $output = drupal_get_form('forward_form', $form);
+    $output .= drupal_get_form('forward_form', $form);
   }
   return $output;
 }

Also, I'm not too sure about some of the changes in function forward_link().

Before the patch, variable "forward_show_on_main" was actually used in forward_link() to determine if the links are to be shown on teasers, which I think is the kind of option we really need. The problem was, the variable was misnamed; it should have been "forward_show_on_teasers". I don't think we need a special case for the home page. So I'd remove the new checks for drupal_is_front_page() and rename the variable. What do you think? If agreed, I can re-roll the patch with that change.

Here is an improved patch that includes the fix in #13 and implements my comment in #14.

This also fixes some uses of t() that caused extractor.php to complain (and would have caused user-entered strings to find their way into the locales table). There were even some nested t()'s in the form of t(variable_get('var', t('str'))); ! These are fixed too.

Ah, and this patch also includes an updated forward.pot file.

I hope everybody will be pleased with this. ;-)

French and Spanish translations of the module are coming soon and will be based on this patch.

FYI: Here is the promised French translation.

A lot of these changes and many others have been made since then so I'm quite cetain the patch will no longer apply. I'm not sure exactly which changes were implemented at this point since I got very busy with other work and lost track of it for a bit. If someone can re-roll the patch against the latest version I'll commit it.

OK, will test this today and hopefully get it committed today or Monday.

Thank you very much, BTW.

Any update on this one? :)

Seems ok...