In russian (and many slavic languages) we use different forms of month names when day of month is present or not.
So we need an additional month name form for this case.

I have done a simple patch which adds nessesary forms that could be added as translations to other languages and this patch still works correctly for english (which do not use this forms).

Thank you for great module.

PS. For russian speaking users I have also post a detailed instractions of how to use this patch to setup correct dates: http://drupal.ru/node/41002 (with screenshots)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aleksey.tk’s picture

subscribing

adubovskoy’s picture

Very useful and necessary patch. Well to see it in following versions of Date

Crazy Joker’s picture

Subscribe

rainbox’s picture

Subscribe

ershov.andrey’s picture

Subscribe

ChemAli’s picture

awsome!

el777’s picture

+1

mr.black’s picture

Subscribe

skylord’s picture

subscribe

rodych’s picture

subscribe

DanilaD’s picture

I subscribe and fully support.

restyler’s picture

+1 for that

DanilaD’s picture

Tested on Drupal 6.15 and Date 6.x-2.4. This patch corrects the writings of month names in Russian on a multilingual site with i18n installed.

drq’s picture

Subscribing. This feature is needed.

mmcmmc’s picture

Subscribe

tema’s picture

Subscribe

crea’s picture

Subs

zio’s picture

Subscribe

ioskevich’s picture

Sub.

dicreat’s picture

subscribe

Andrew Gorokhovets’s picture

Very important for me!

stokito’s picture

+1

sashken2’s picture

subscribe

areafix’s picture

subscribe

Anton.Safin’s picture

Subscribe. Very useful!

Captain Flint’s picture

subscribe

bsyomov’s picture

+1

namli’s picture

+1

dgastudio’s picture

+1

andyceo’s picture

Subscribing! Very needed patch.

robby.smith’s picture

subscribing

can this be expanded to allow different order of month/day/year dropdown selectlist depending on language? for example, if language A mm/dd/yy and if language B yy/mm/dd

crea’s picture

Status: Needs review » Needs work
t('!month-genitive |January|February|March|April|May|June|July|August|September|October|November|December', array('!month-name' => '')

should be

t('!month-genitive |January|February|March|April|May|June|July|August|September|October|November|December', array('!month-genitive' => '')
kettari’s picture

subscribing

ALexeyAL1’s picture

subscribing

YK85’s picture

subscribing

RoSk0’s picture

Subscribing! Very needed patch.

kettari’s picture

Any chances this would be applied to the module Date?

dgastudio’s picture

+1.
3 months to commit...

darkkin’s picture

Subscribing

lolmaus’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
1.62 KB

Patch fixed according to #32 suggestion.

Come on, Date devs! This is a MUCH demanded feature among Russian, Ukrainian, Polish, Belorussian, Slovak, Slovenian, Czech, Bulgarian, Macedonian, Bosnian, Serbian, Croatian and Montenegrin users.

files32’s picture

I hope that this patch will be inserted into the following release.

trollfred’s picture

+1

YK85’s picture

tested and works great!
+1 for commit

piotrly’s picture

Date module is unusable for me without this patch. Unfortunately there is some problem in 2.6 version - when editing node, month-genitive is default and can't save node without changing date.

dgastudio’s picture

but, does it work with views?

KarenS’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Does #44 indicate there is a problem with the patch? Please confirm that.

lolmaus’s picture

Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

2 KarenS #46

I'm using patched Date on all my sites. Node editing is okay. Saving and displaying is okay. I believe that piotrly #44 should clarify his issue and provide steps to reproduce it.

VladSavitsky’s picture

piotrly, please tell which version of patch did you used?
I have used and tested version attached to this comment (the same as in start topic with out changes #33).

KarenS’s picture

Status: Reviewed & tested by the community » Needs work

For those who are upset that this is not yet committed -- read back through this issue -- everyone says 'subscribe' or '+1' but no one says they have tested it. Then we have a report that it needs work and it is changed and immediately marked ready to commit, but again no one reports that they have tested it until one report in #43 that it (which patch? the one with the fix in #32 or the original?) works. We also have a report in #44 that it does not work.

I see only three reports that it was tested, one is for a different patch and one is a report that it did not work.

Don't grumble that I haven't committed this, please do more than say '++'; Tell me that you have tested it and *which* thing you are testing and please someone confirm what is going on with the report that it didn't work.

KarenS’s picture

Actually there's something else that needs to be tested in addition. I'm pretty sure this will work fine in English since that is the base language, but I suspect this may break languages that don't use month-genetive. I suspect we need a test for whether there is a non-English value in month-genetive before we use it to ensure that it doesn't pop back to English for languages that have nothing in that value. I'm not even sure of the best way to do this but you need to use something like French (where we have a good current translation that does not have that value populated) to be sure that the right value is returned for them.

lolmaus’s picture

KarenS, here's a live site in Russian with #40 patch: http://zhso.ru/

If you're still unsure it's working, i can clone the site for you and grant you editor permissions.

As for #44, the guy didn't supply his report with steps to reproduce. It's unclear what happened with his site and i don't experience his issue as well.

KarenS’s picture

What about a French site? We need to confirm what happens on a French site that has no French values for genetive.If I read this right, it will end up with English values instead of French values if the pattern meets the criteria. See my comments in #51. You can wait for me to test and research if that it is a problem and try to find a fix if it does, or someone can check that out for me. If you want me to figure this out by myself, you may have a wait. If you're anxious to get this committed someone can test this for me.

Please understand that I have to not only know if it works right for you, I have to be sure it won't break things for anyone else.

emillemay’s picture

subscribing

bora-89’s picture

This patch still is not included to the module, right?

lolmaus’s picture

bora-89, not icluded. The maintainer wants it to be tested on a non-cyrillic site, like French.

VVS’s picture

need

RedRat’s picture

Still waiting...

unic’s picture

This patch solve month names in Date module, but same problem is in other modules and Drupal core. See format_date in common.inc, titles for argument with node creation month (when used with day argument) in Views, etc.

OnkelTem’s picture

Category: feature » bug
Status: Needs work » Active

Still no support for 7.x? Also, this patch is not applied to 7.x branch.

OnkelTem’s picture

Category: bug » feature

I would gladly mark this as a bug and set its status to critical, but this is not the case. Drupal's internal weird dates processing, based on PHP's dates but with locale stuff cut off makes things so bad. I hate this, honestly.

KarenS’s picture

Status: Active » Postponed (maintainer needs more info)

I asked questions in #49, #50, and #51. No one has answered all of them. Nothing will happen to this patch until someone responds to those.

This does not apply to 7.x where multilingual is handled by core.

arlinsandbulte’s picture

Status: Postponed (maintainer needs more info) » Closed (works as designed)

No response or follow-up after 4+ months at 'postponed (maintainer needs more info)'
Marking closed...

chernetsky’s picture

+1

divined’s picture

+1000000000

Sutry’s picture

Subscribe

le72’s picture

Issue summary: View changes

+1

RedRat’s picture

There is no point in subscribing 'cause this issue is closed.