Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In russian (and many slavic languages) we use different forms of month names when day of month is present or not.
So we need an additional month name form for this case.
I have done a simple patch which adds nessesary forms that could be added as translations to other languages and this patch still works correctly for english (which do not use this forms).
Thank you for great module.
PS. For russian speaking users I have also post a detailed instractions of how to use this patch to setup correct dates: http://drupal.ru/node/41002 (with screenshots)
Comment | File | Size | Author |
---|---|---|---|
#48 | date_api.module_#728350.patch | 1.62 KB | VladSavitsky |
#40 | date_api.module.patch | 1.62 KB | lolmaus |
date_api.module.patch | 1.62 KB | VladSavitsky | |
Comments
Comment #1
aleksey.tk CreditAttribution: aleksey.tk commentedsubscribing
Comment #2
adubovskoy CreditAttribution: adubovskoy commentedVery useful and necessary patch. Well to see it in following versions of Date
Comment #3
Crazy Joker CreditAttribution: Crazy Joker commentedSubscribe
Comment #4
rainbox CreditAttribution: rainbox commentedSubscribe
Comment #5
ershov.andrey CreditAttribution: ershov.andrey commentedSubscribe
Comment #6
ChemAli CreditAttribution: ChemAli commentedawsome!
Comment #7
el777 CreditAttribution: el777 commented+1
Comment #8
mr.black CreditAttribution: mr.black commentedSubscribe
Comment #9
skylord CreditAttribution: skylord commentedsubscribe
Comment #10
rodych CreditAttribution: rodych commentedsubscribe
Comment #11
DanilaD CreditAttribution: DanilaD commentedI subscribe and fully support.
Comment #12
restyler CreditAttribution: restyler commented+1 for that
Comment #13
DanilaD CreditAttribution: DanilaD commentedTested on Drupal 6.15 and Date 6.x-2.4. This patch corrects the writings of month names in Russian on a multilingual site with i18n installed.
Comment #14
drq CreditAttribution: drq commentedSubscribing. This feature is needed.
Comment #15
mmcmmc CreditAttribution: mmcmmc commentedSubscribe
Comment #16
tema CreditAttribution: tema commentedSubscribe
Comment #17
crea CreditAttribution: crea commentedSubs
Comment #18
zio CreditAttribution: zio commentedSubscribe
Comment #19
ioskevich CreditAttribution: ioskevich commentedSub.
Comment #20
dicreat CreditAttribution: dicreat commentedsubscribe
Comment #21
Andrew Gorokhovets CreditAttribution: Andrew Gorokhovets commentedVery important for me!
Comment #22
stokito CreditAttribution: stokito commented+1
Comment #23
sashken2 CreditAttribution: sashken2 commentedsubscribe
Comment #24
areafix CreditAttribution: areafix commentedsubscribe
Comment #25
Anton.Safin CreditAttribution: Anton.Safin commentedSubscribe. Very useful!
Comment #26
Captain Flint CreditAttribution: Captain Flint commentedsubscribe
Comment #27
bsyomov CreditAttribution: bsyomov commented+1
Comment #28
namli CreditAttribution: namli commented+1
Comment #29
dgastudio CreditAttribution: dgastudio commented+1
Comment #30
andyceo CreditAttribution: andyceo commentedSubscribing! Very needed patch.
Comment #31
robby.smith CreditAttribution: robby.smith commentedsubscribing
can this be expanded to allow different order of month/day/year dropdown selectlist depending on language? for example, if language A mm/dd/yy and if language B yy/mm/dd
Comment #32
crea CreditAttribution: crea commentedshould be
Comment #33
kettari CreditAttribution: kettari commentedsubscribing
Comment #34
ALexeyAL1subscribing
Comment #35
YK85 CreditAttribution: YK85 commentedsubscribing
Comment #36
RoSk0Subscribing! Very needed patch.
Comment #37
kettari CreditAttribution: kettari commentedAny chances this would be applied to the module Date?
Comment #38
dgastudio CreditAttribution: dgastudio commented+1.
3 months to commit...
Comment #39
darkkin CreditAttribution: darkkin commentedSubscribing
Comment #40
lolmaus CreditAttribution: lolmaus commentedPatch fixed according to #32 suggestion.
Come on, Date devs! This is a MUCH demanded feature among Russian, Ukrainian, Polish, Belorussian, Slovak, Slovenian, Czech, Bulgarian, Macedonian, Bosnian, Serbian, Croatian and Montenegrin users.
Comment #41
files32 CreditAttribution: files32 commentedI hope that this patch will be inserted into the following release.
Comment #42
trollfred CreditAttribution: trollfred commented+1
Comment #43
YK85 CreditAttribution: YK85 commentedtested and works great!
+1 for commit
Comment #44
piotrly CreditAttribution: piotrly commentedDate module is unusable for me without this patch. Unfortunately there is some problem in 2.6 version - when editing node, month-genitive is default and can't save node without changing date.
Comment #45
dgastudio CreditAttribution: dgastudio commentedbut, does it work with views?
Comment #46
KarenS CreditAttribution: KarenS commentedDoes #44 indicate there is a problem with the patch? Please confirm that.
Comment #47
lolmaus CreditAttribution: lolmaus commented2 KarenS #46
I'm using patched Date on all my sites. Node editing is okay. Saving and displaying is okay. I believe that piotrly #44 should clarify his issue and provide steps to reproduce it.
Comment #48
VladSavitsky CreditAttribution: VladSavitsky commentedpiotrly, please tell which version of patch did you used?
I have used and tested version attached to this comment (the same as in start topic with out changes #33).
Comment #49
KarenS CreditAttribution: KarenS commentedFor those who are upset that this is not yet committed -- read back through this issue -- everyone says 'subscribe' or '+1' but no one says they have tested it. Then we have a report that it needs work and it is changed and immediately marked ready to commit, but again no one reports that they have tested it until one report in #43 that it (which patch? the one with the fix in #32 or the original?) works. We also have a report in #44 that it does not work.
I see only three reports that it was tested, one is for a different patch and one is a report that it did not work.
Don't grumble that I haven't committed this, please do more than say '++'; Tell me that you have tested it and *which* thing you are testing and please someone confirm what is going on with the report that it didn't work.
Comment #50
KarenS CreditAttribution: KarenS commentedActually there's something else that needs to be tested in addition. I'm pretty sure this will work fine in English since that is the base language, but I suspect this may break languages that don't use month-genetive. I suspect we need a test for whether there is a non-English value in month-genetive before we use it to ensure that it doesn't pop back to English for languages that have nothing in that value. I'm not even sure of the best way to do this but you need to use something like French (where we have a good current translation that does not have that value populated) to be sure that the right value is returned for them.
Comment #51
lolmaus CreditAttribution: lolmaus commentedKarenS, here's a live site in Russian with #40 patch: http://zhso.ru/
If you're still unsure it's working, i can clone the site for you and grant you editor permissions.
As for #44, the guy didn't supply his report with steps to reproduce. It's unclear what happened with his site and i don't experience his issue as well.
Comment #52
KarenS CreditAttribution: KarenS commentedWhat about a French site? We need to confirm what happens on a French site that has no French values for genetive.If I read this right, it will end up with English values instead of French values if the pattern meets the criteria. See my comments in #51. You can wait for me to test and research if that it is a problem and try to find a fix if it does, or someone can check that out for me. If you want me to figure this out by myself, you may have a wait. If you're anxious to get this committed someone can test this for me.
Please understand that I have to not only know if it works right for you, I have to be sure it won't break things for anyone else.
Comment #53
emillemay CreditAttribution: emillemay commentedsubscribing
Comment #54
bora-89 CreditAttribution: bora-89 commentedThis patch still is not included to the module, right?
Comment #55
lolmaus CreditAttribution: lolmaus commentedbora-89, not icluded. The maintainer wants it to be tested on a non-cyrillic site, like French.
Comment #56
VVS CreditAttribution: VVS commentedneed
Comment #57
RedRat CreditAttribution: RedRat commentedStill waiting...
Comment #58
unic CreditAttribution: unic commentedThis patch solve month names in Date module, but same problem is in other modules and Drupal core. See format_date in common.inc, titles for argument with node creation month (when used with day argument) in Views, etc.
Comment #59
OnkelTem CreditAttribution: OnkelTem commentedStill no support for 7.x? Also, this patch is not applied to 7.x branch.
Comment #60
OnkelTem CreditAttribution: OnkelTem commentedI would gladly mark this as a bug and set its status to critical, but this is not the case. Drupal's internal weird dates processing, based on PHP's dates but with locale stuff cut off makes things so bad. I hate this, honestly.
Comment #61
KarenS CreditAttribution: KarenS commentedI asked questions in #49, #50, and #51. No one has answered all of them. Nothing will happen to this patch until someone responds to those.
This does not apply to 7.x where multilingual is handled by core.
Comment #62
arlinsandbulte CreditAttribution: arlinsandbulte commentedNo response or follow-up after 4+ months at 'postponed (maintainer needs more info)'
Marking closed...
Comment #63
chernetsky CreditAttribution: chernetsky commented+1
Comment #64
divined CreditAttribution: divined commented+1000000000
Comment #65
Sutry CreditAttribution: Sutry commentedSubscribe
Comment #66
le72+1
Comment #67
RedRat CreditAttribution: RedRat commentedThere is no point in subscribing 'cause this issue is closed.