I have set my Page content type to auto-publish revisions for moderators.
I gave my "author" role permission to "publish revisions" like it says you need to do. When this author makes changes to his own node and saves them, he is shown his edits as a pending revision even though the current page also says at the top "Auto-publishing this revision. Page Test has been updated" - so Im not sure why it says this if it still requires them to click the "publish this" link.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | revisioning.module.patch | 440 bytes | Jonah Ellison |
Comments
Comment #1
Jonah Ellison commentedI've experienced this also... I think the "New revision in draft, pending moderation" checkbox overrides the auto-publish. I've attached the patch I've used to get around this. It adds:
$node->revision_moderation = FALSE;after line 759.Comment #2
rdeboerThanks for the patch!
Alternatively check out the latest versions (HEAD) of both Module Grants and Revisioning from CVS. For some reason dev tar balls don't get generated for my modules anymore.
Rik
Comment #3
rdeboerFixed in 6.x-3.5
Comment #4
j0k3z commentedJust downloaded 6x3.5 and it doesnt seem to be fixed.
Can you please confirm
Comment #5
rdeboerDarn... Will look into it - Rik
Comment #6
rdeboerAnother attempt to fix committed to repository (HEAD). May be checked out now. or willl be available in 6.x-3.6
Comment #7
gtownwaldo commentedI just tried the latest CVS patch, it kinda works, but not totally.
If you edit page content with the proper permissions it will not autopublish and will create a new revision.
However, if you then edit the that revision you just created and save that it will autopublish.
Comment #8
rdeboerThat's pretty slack by me. Will REALLY fix soon.
Comment #9
rdeboer@gtownwaldo
I just tried to reproduce what you wrote in #7, but can't.
By proper permission you mean 'publish revisions', right? And for the content type in question (e.g page, story...) you have "Auto-publish drafts of type ...." ticked on the Content management >> Content types >> edit page?
On my system the page does get auto-published, whether it is a newly created one, or a new revision of an existing page.
Can you please double-check?
Rik
Comment #10
gtownwaldo commentedI just double-checked and I am getting that problem. I am running domain access as well, and I have tried different combinations of those permissions but that doesn't seem to effect it. And yes, these are the boxes I have checked
I have tried also with the published boxed checked both on and off
Create new revision
New revision in draft, pending moderation (requires "Create new revision")
Only when saving page content that is not already in draft/pending moderation
Auto-publish drafts of type page (for moderators)
and I am editing from the user 1 account with publish revisions.
Here's exactly what is occurring. When I click my edit tab I go here
/node/10/edit when I save this page it creates a new revision but doesn't publish it.
However if I go to the saved revision of the current visible page or of a revision I've already made and edit that
/node/10/revisions/367/view
/node/10/revisions/367/edit
It will auto publish.
Is there any more information you need?
Comment #11
j0k3z commentedWhere do I download this latest version? I am happy to test as well but dont know where you get the latest version
Comment #12
rdeboer@gtownwaldo, #10
First, as an aside, when you're logged in as user 1, you automatically have ALL permissions, so ticking/unticking permissions will not make a difference.
I have once more tried to reproduce this but couldn't. Maybe domain access is throwing a spanner in the works but I doubt it.
In my case, also logged in as user 1, with the content type settings as you report, every new revision, whether it is the very first (i.e. new content) or any subsequent revision, becomes current & published immediately.
@j0k3z, #11
If you don't have the option to check out the latest CVS HEAD from the repository... I have just created a new version of Revisioning (6.x-3.6 which has the start of a Views integration) that you could try, to see if you have more luck with reproducing the alleged bug. Thanks for your help!
Comment #13
gtownwaldo commentedIt is working perfectly in the latest release 3.6.
Comment #14
rdeboerGreat! I was about to start pulling my hair out!
Comment #15
j0k3z commentedworking great -- thanks