Theres got to be a missing check for the pubsubhubbub stuff. Im trying to use an iCal parser, which of course is *not* xml.

It is currently breaking with this message:

Fatal error: Uncaught exception 'Exception' with message 'String could not be parsed as XML' in /home/eatpdx/eatpdx.org/dev/sites/all/modules/feeds/libraries/PuSHSubscriber.inc:79
Stack trace:
#0 /home/eatpdx/eatpdx.org/dev/sites/all/modules/feeds/libraries/PuSHSubscriber.inc(79): SimpleXMLElement->__construct('BEGIN:VCALENDAR...')
#1 /home/eatpdx/eatpdx.org/dev/sites/all/modules/feeds/plugins/FeedsHTTPFetcher.inc(158): PuSHSubscriber->subscribe('http://eatpdx.o...', 'http://www.eatp...', '')
#2 /home/eatpdx/eatpdx.org/dev/sites/all/modules/feeds/plugins/FeedsHTTPFetcher.inc(143): FeedsHTTPFetcher->subscribe(Object(FeedsSource))
#3 /home/eatpdx/eatpdx.org/dev/sites/all/modules/feeds/includes/FeedsSource.inc(179): FeedsHTTPFetcher->sourceSave(Object(FeedsSource))
#4 /home/eatpdx/eatpdx.org/dev/sites/all/modules/feeds/feeds.pages.inc(82): FeedsSource->save()
#5 /home/eatpdx/eatpdx.org/dev/includes/form.inc(776): feeds_import_form_submit(Array, Array)
#6 /home/eatpdx/eatpdx.org/dev/includes/form.inc(416): form_execute_handle in /home/eatpdx/eatpdx.org/dev/sites/all/modules/feeds/libraries/PuSHSubscriber.inc on line 79

From what I can gather, line 143 of the FeedsHTTPFetcher file is calling subscribe, which is implemented in the PuSHSubscriber.inc file.

My configurartion: brand new site with the latest versions of iCalParser and Feeds. I have this up to use the /import form, as opposed to attaching the feed to a node.

I *definitely* do not have usepubsubhub checked on the FeedsHTTPFetcher input form.

I cant for the life of me figure out where the check should go, it seems as though this pubsubhub stuff is now everywhere in the code..

Architecturally speaking, wouldnt it be nicer to have a FeedsHTTPFetcher that *only* does HTTP and has *no concept* of pubsubhubbub, and have a separate PubSubHubBubFetcher? - maybe I dont understand the purpose behind pubsubhubbub.

Comments

alex_b’s picture

alex_b commented
Status: Active » Fixed

Sorry - this glitch is fixed in head. You can alternatively apply this patch:

http://drupalcode.org/viewvc/drupal/contributions/modules/feeds/plugins/...

Architecturally speaking, wouldnt it be nicer to have a FeedsHTTPFetcher that *only* does HTTP and has *no concept* of pubsubhubbub

Yeah, I've been there... the problem with this approach is that it becomes more difficult for add on modules to customize the behavior of Feeds as they suddenly need to override 2 classes instead of one. I'd love to keep HTTP fetching under one roof - at least for now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.