Download & Extend
Views Display Tabs » Issues

Turning off "Show when empty" still shows other tabs with no results

Posted by ManyNancy on March 6, 2010 at 8:34am
Project:Views Display Tabs
Version:6.x-1.0-beta6
Component:Code
Category:bug report
Priority:major
Assigned:Unassigned
Status:needs review

Issue Summary

If I leave show when empty unchecked, the tab of the empty view is still shown. Clicking to it makes the whole tabset disappear! - #734070: Empty views causes tabs to disappear

Isn't the behavior supposed to be, if show when empty is unchecked, the empty tab is not shown?

Thanks for making this great module.

Login or register to post comments

Comments

#1

Posted by kirbaranov on March 9, 2010 at 5:49pm

subscribe

#2

Posted by 4kant on May 1, 2010 at 10:10am

subscribe

#3

Posted by mzwyssig on September 3, 2010 at 7:28am

Subscribe.

#4

Posted by mzwyssig on September 3, 2010 at 7:29am
Priority:normal» major

#5

Posted by vlooivlerke on March 4, 2011 at 12:24pm

This is a serious problem. You are also unable to hide a normal view tab if the view is empty. There are plenty treads trying to solve this issue but none was successful.

I thought this module was a solution but now it has the same problem as views tabs.
It shows if the view is empty. Why would you want a button that point to nothing?

#6

Posted by iNade on March 27, 2011 at 2:34pm

Subscribing

#7

Posted by ramlev on April 6, 2011 at 12:59pm

I have done a patch, which seems to fix the issue in the 6.x-1.0-beta6 version.

Dont have done the check in $show , since i believe that the author have another thought on this variable.

Please lemme know if it's all good

AttachmentSize
734380.patch 1.3 KB

#8

Posted by ramlev on April 6, 2011 at 1:12pm

A new and updated patch is attached, a minor bug is fixed.

It now works if your view contains any arguments.

AttachmentSize
734380_1.patch 2.06 KB

#9

Posted by vlooivlerke on April 7, 2011 at 5:27pm

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 80 bytes) in /sites/all/modules/views/includes/base.inc on line 88

I get this error message when I patch the module and visit a views display tabs website.

My memory limit is 128m.

#10

Posted by ramlev on April 7, 2011 at 7:46pm

I have added a new patch, which is removing the view variable after testing if the view tab is containing any data, this should free up a lot of memory.

You should replace the old patch with this one

AttachmentSize
734380_2.patch 2.81 KB

#11

Posted by vlooivlerke on April 8, 2011 at 6:15am

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 78 bytes) in /sites/all/modules/views/plugins/views_plugin_display.inc on line 223

and

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 76 bytes) in /home/wiki/public_html/sites/all/modules/views/includes/base.inc on line 100

still some errors.

#12

Posted by vlooivlerke on April 11, 2011 at 4:43pm

ok I increased my memory limit to 256M but still get the same errors, it even use more memory.

http://utopiaclivias.co.za/ here is a link to show you that my tab menus are not that extensive to use so much memory.

Or I must be patching the wrong version.

#13

Posted by udane on April 29, 2011 at 10:45am

I have the same problem. Is there a solution?
Thanks.

#14

Posted by mindaugasd on September 21, 2011 at 11:48am

sub

#15

Posted by smokris on April 29, 2012 at 2:27am
Title:Turning off show when empty does not work» Turning off "Show when empty" still shows other tabs with no results
Status:active» needs review

Revised patch attached, which applies cleanly to 6.x-1.0-beta6. Works for me with views-6.x-2.16 (no memory issues as reported above).

AttachmentSize
734380_3.patch 863 bytes