Needs review
Project:
Views Display Tabs
Version:
6.x-1.0-beta6
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Mar 2010 at 08:34 UTC
Updated:
28 Dec 2012 at 10:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedsubscribe
Comment #2
4kant commentedsubscribe
Comment #3
mzwyssig commentedSubscribe.
Comment #4
mzwyssig commentedComment #5
vlooivlerke commentedThis is a serious problem. You are also unable to hide a normal view tab if the view is empty. There are plenty treads trying to solve this issue but none was successful.
I thought this module was a solution but now it has the same problem as views tabs.
It shows if the view is empty. Why would you want a button that point to nothing?
Comment #6
iNade commentedSubscribing
Comment #7
ramlev commentedI have done a patch, which seems to fix the issue in the 6.x-1.0-beta6 version.
Dont have done the check in $show , since i believe that the author have another thought on this variable.
Please lemme know if it's all good
Comment #8
ramlev commentedA new and updated patch is attached, a minor bug is fixed.
It now works if your view contains any arguments.
Comment #9
vlooivlerke commentedFatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 80 bytes) in /sites/all/modules/views/includes/base.inc on line 88
I get this error message when I patch the module and visit a views display tabs website.
My memory limit is 128m.
Comment #10
ramlev commentedI have added a new patch, which is removing the view variable after testing if the view tab is containing any data, this should free up a lot of memory.
You should replace the old patch with this one
Comment #11
vlooivlerke commentedFatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 78 bytes) in /sites/all/modules/views/plugins/views_plugin_display.inc on line 223
and
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 76 bytes) in /home/wiki/public_html/sites/all/modules/views/includes/base.inc on line 100
still some errors.
Comment #12
vlooivlerke commentedok I increased my memory limit to 256M but still get the same errors, it even use more memory.
http://utopiaclivias.co.za/ here is a link to show you that my tab menus are not that extensive to use so much memory.
Or I must be patching the wrong version.
Comment #13
udane commentedI have the same problem. Is there a solution?
Thanks.
Comment #14
mindaugasd commentedsub
Comment #15
smokrisRevised patch attached, which applies cleanly to 6.x-1.0-beta6. Works for me with views-6.x-2.16 (no memory issues as reported above).
Comment #16
crash98 commented#15 also works for me with Views 6.x-2.16. Thx.