Closed (won't fix)
Project:
Chatroom
Version:
master
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Jul 2006 at 23:02 UTC
Updated:
9 Oct 2006 at 14:58 UTC
Jump to comment: Most recent
Comments
Comment #1
pacheco commentedwe will have to dig that a litlle deeper...
i've applied your patch im my install and it breaks some allready suported chars like "á", "é", "ç"...
maybe it needs some other changes to work well
Comment #2
Anonymous (not verified) commentedhi stefan and paulo,
i tested stefan's patch on the latest cvs, and i is working as advertised.
paulo, this includes with the characters that aren't working for you - could retest at http://drupal.ceeceekay.net and see if you still have any problems?
if not, i'm going to make this change - thanks stefan.
cheers
justin
Comment #3
pacheco commentedreally strange, its not working at all in my host, look:
http://dev.ppacheco.com/chatrooms/chat/3
maybe it depends on some else from server...
Comment #4
pacheco commentedok, i've added utf8_decode in chatroomread.php, so this:
became:
and now it works for me, but i'm anger to rear someone explananing why it worked in your enviroment without this function and not in my.
still think it has something to do with the server config...
Comment #5
Anonymous (not verified) commentedi've committed a fix for this.
the javascript now uses encodeURIComponent(), and the php checks the value of get_magic_quotes_gpc() to decide whether to call utf8_decode, and it works fine either way.
thanks again stefan for the encodeURIComponent patch.
Comment #6
Anonymous (not verified) commentednot sure what this says, but i got it from here, and it doesn't work in the chatroom at the moment.
we need to do some work on making these sorts of characters work with the chatroom.
any help is much appreciated.
Comment #7
Anonymous (not verified) commentedi read through drupal.js a little more carefully, and it turns out that encodeUriComponent() is already called on the content we send back to the server.
sooo, the problem looks like being with mysql. on my install at home (mysql 5.0.22), setting the character type to utf8 fixed the problem. this is not an option for mysql versions less than 4.1 though, which is probably still the majority of users out there, so we need a fallback.
i'd like to spend some time on fixing this this weekend - suggestions anyone?
Comment #8
Anonymous (not verified) commentedi've added some code to the install file that will set the default charset to utf8 if the mysql version is greater than 4.1.
this should fix display of multibyte chars for mysql greater than 4.1.
Comment #9
Anonymous (not verified) commentedComment #10
darren oh