Need ability to allow links in header to be functional

Thanks for the patch cap60552, will review it as soon as my schedule allows for me to work peacefully on the issue queue again.

Reading the patch, it looks ok to me. However, this patch was not rolled against the latest dev of the module, so it fails to apply, specifically on the js file.

Since this is a simple patch, I went ahead and re-rolled it for our latest dev, find it attached.

I have committed this already, should be available in the dev version in a while. Thanks!

Thank you for the function, only:

it would be nice having a link in the header, if you click on it, that it does not open/close the node.

I am not sure where to place the :not(a) in the code.

OK, I've gone ahead and taken a look at this funkytraffic, please test the attached patch, in as many browsers as you can (IE, chrome, safari, ff is already tested), since I am checking for .originalTarget.tagName, and I'm not sure this is available on all browsers.

OK, ignore the last patch, I've found out that originalTarget.tagName breaks in chrome. The attached patch uses ev.target.nodeName, which works both on FF and Chrome. We need to test this in IE and safari at least for this patch to get in, can you help here?

Works great in FF 3.6

This was a fast reply!

Will test it in IE and Safari on W7, wait a minute.

Test on Windows 7 - XAMPP running with Safari 5.02 an IETester for IE 6,7 & 8.

Works great!

Will upload it to dasdossier.de/magazin later.Look at the sidebar there.

Thats good news funkytraffic, it even works on ie6, that's a good sign.

I've already committed the patch to CVS, so the latest dev version of the module will have it when the package generator rebuilds de tarball. Thanks for testing!

When clicking on a link the accordion still activates. I propose to catch that it was a link that was clicked so that the accordion is not popped down and that the link's destination begins to load. Right now, the destination begins to load, but the browser sits on the current page for a bit and the accordion pops down, which seems to throw off users since they don't expect the link to show them content on the current page AND go to a new one. It's reasonable to think that if a user clicks a link they want to navigate away and aren't concerned with the content exposed by the accordion. Thoughts?

Does anyone else see a need for such functionality? I'm surprised there were no responses given this module is "Actively maintained."

Yup, no response because people have a life to take care of besides giving free code and support to the world.

That said, I do see that as something that would be nice to have, I would accept patches implementing it properly.

>Yup, no response because people have a life to take care of besides giving free code and support to the world.

True. Is this meant to be rude though? It comes off that way.

I would've submitted a patch, but I merely asked for an opinion on whether this was desirable functionality. Why submit a patch before I know if this is desirable functionality or not? Should I go ahead with this, learn your code, and submit a patch? Seems very easy to do...

Like I said, I would accept (good) patches in this direction.

Closing now due to 6.x no longer supported.