When one chooses the thumbnailhover mode and node display, the only options for the thumbnail fields are teaser or full node display. It would be really useful if title could be there as well, so it could be used as a tab to display the nodes. This patch implements that, although it does a node load for each title which might be not the best for efficiency.

CommentFileSizeAuthor
#4 743694-remove-dsm.patch1.12 KBsnufkin
#2 743694-title-1.diff2.61 KBredndahead
title_tab_nodestyle.patch2.56 KBsnufkin

Comments

redndahead’s picture

redndahead commented
Priority: Normal » Critical

Marking as critical to look at before release

redndahead’s picture

redndahead commented
StatusFileSize
new 743694-title-1.diff2.61 KB

This was committed with the changes in this patch.

redndahead’s picture

redndahead commented
Status: Needs review » Fixed
snufkin’s picture

snufkin commented
Title: vs_thumnailhover: Allow title to be used as the breakout field on node style » Allow title to be used as the breakout field on node style - dsm left in commit
Status: Fixed » Needs review
StatusFileSize
new 743694-remove-dsm.patch1.12 KB

There was a dsm() committed with this patch, here is a fix for that. Should I go ahead and commit it?

redndahead’s picture

redndahead commented
Status: Needs review » Reviewed & tested by the community

Yes please commit it. Aargh.

snufkin’s picture

snufkin commented
Status: Reviewed & tested by the community » Fixed

Done.

redndahead’s picture

redndahead commented
Status: Fixed » Postponed (maintainer needs more info)

I don't see the commit message. Are you sure you committed it?

snufkin’s picture

snufkin commented

Oh hmm i was too quick to call it, didnt pay attention to the output. I don't have access to the repo:

cvs [server aborted]: "commit" requires write access to the repository

redndahead’s picture

redndahead commented

hmm strange. I'll commit it and look into your access later. Did you login to cvs?

redndahead’s picture

redndahead commented
Status: Postponed (maintainer needs more info) » Fixed

This has been committed.

snufkin’s picture

snufkin commented

Yeah, i did log in. But even the cvs instruction tab on the project page suggests i dont have access though:
http://files.freestylesystems.co.uk/snufkin/image/Firefox-20100414-01444...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.