Closed (fixed)
Project:
Inline Form Errors
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Mar 2010 at 13:40 UTC
Updated:
25 Apr 2019 at 11:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
stijndm commentedThanks for this patch. I had my own ideas on how to implement a site-wide enable, but I'll definitely have a look at this patch.
- I think there should be a distinction between frontend and backend, maybe integrate with admin_theme somehow
- Individual settings should remain in tact, but I think this patch covers that
Anyway, I hadn't considered a sitewide enable yet, just a front end enable. With the settings from admin_theme I could then check what else would be considered frontend/backend.
Comment #2
stijndm commentedAdditionaly an option should be provided to 'ignore' the sitewide setting on individual forms allowing to disable IFE on certain forms if desired.
Comment #3
swentel commentedHmm #2 is valid true - updated the patch - tiny error in $display check.
Comment #4
swentel commentedApart from a global setting, there is a racing condition problem too. It's sometimes dangerous to let IFE take over the theming of a form element when the form itself also has a theming function. Menu table dragging stops working because the parent element is rendered too soon - in fact, most forms with table drag did. Haven't tested it on others, but it's likely to happen now and then. Not sure what the best approach is, but it's good to know this problem for future bug reports :)
Comment #5
stijndm commentedI know, it's for the same reasen filefield/imagefield don't work.
I'm looking in to different approaches, but nothing definite yet.
Comment #6
stijndm commentedComment #7
firebus commentedIt would also be nice to allow ife for all forms provided by a specific module (webform for example) or to allow a wildcard in form_if (webform_client_form_* for example)
should that be a separate feature request/patch?
Comment #8
firebus commentedThe patch in #3 did not apply cleanly for me (patch complained of a malformed patch in the ife.module section) but once I manually applied the changes, it worked great. Thank you!
Comment #9
firebus commentedthis patch breaks tabledrag.js on admin/build/menu-customize/menu-name. probably also on admin/build/block
this makes it impossible to sort menu items with ife enabled.
it would be probably be good to add a form id blacklist so that core drupal functionality isn't broken
Comment #10
firebus commentedHere is a patch against 6.x-1.x-dev that adds a black list of core drupal forms that are incompatible with ife because of tabledrag.
Comment #11
stijndm commentedMoving this to D7 branch
Comment #12
stijndm commentedComment #13
marcusx commentedHere is a slightly refurbished version of #10 against the latest 7.x-dev.
A separate checkbox for adding ife to all webforms could improve this even more. My main reason for patching ife that it is to complicated for editors who create webforms to get the form id and add the id to the configuration for each webform.
But maybe it is ok to use ife anywhere. It will test this now with the global setting and report back if things break as I am using a lot of inline forms and stuff on the site I am using this and I wouldn't be suprised if the blacklist isn't enough.
Comment #14
BarisW commentedPatch works good. Thanks! Can this be committed?
Comment #15
ram4nd commentedNeeds a re-roll. Does not apply to dev.
Comment #16
michel.settembrino commentedPatch re-rolled for current dev version.
Comment #17
scuba_fly+1 #16 works for me.
Comment #18
ram4nd commentedRe-roll does not work for me. The branch in the issue is 7.x-2.x.
Comment #19
dani3lr0se commented#16 does not work me either. I tried applying the patch to the current dev version with no luck.
Comment #20
paulvandenburg commentedRerolled the patch.
Comment #21
ram4nd commentedLooks like you missed a line.
Comment #22
paulvandenburg commentedNo the vset part is removed and no longer relevant.
Comment #24
ram4nd commented