The tab "Votes" shows up for users with user_access('administer votes') in any case.
However - content is only displayed if poll has enabled "show votes".
I'd vote to show votes in any case for users with user_access('administer votes') without considering vote settings.
Patch adds this condition.

CommentFileSizeAuthor
poll_access_votes.patch874 bytesmiro_dietiker

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Needs review

forgot to change state to review.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

note the related issue

#546518: Results tab not displayed

Whereas it's about enabling the tab, while in this case the tab is available but the votes aren't getting displayed.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Assigned: Unassigned » miro_dietiker

Assigning this to my current bugfix cycle.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

committed to cvs leading to 1.21.2.88.2.26

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Assigned: miro_dietiker » Unassigned

unassign me

roball’s picture

roball commented
Status: Fixed » Needs work

But this makes it impossible to have secret votes as known from real political elections. If you want to make a secret election, administrators may administer the poll, but should also NOT see who voted for what.

If the "Show individual votes" checkbox is unchecked, I would expect NOT to show the individual votes, under no circumstances. Of course, if no votes are displayed, the "Votes" tab should not appear as well. This is also the way the Decisions module handles this case. Please reconsider your patch to respect the "Show individual votes" setting? Thanks!

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Roball
The checkbox can be changed at any time (am i wrong?). Thus no real "secret" votes will ever be possible.
I consider administrator permissions as permissions that override all limitations. Our x-administrators are very confused if they are not permitted for some specific task and start to fire bug tickets.
"It's a vote - i'm administrator - why can't i see the votes? where's the tab?"

Indeed, the question is -- what this checkbox exactly is for. I might have misunderstood that.
Is there a message or explanation that currently promise that this function really hides the votes from everybody?
(seems i didn't consider this use-case)

There are further permission issues with the module... I will continue fixing them.

I'm not deadlocked to my current interpretation and many current permission issues need complete rethought (for all kinds of cases) and correct interpretation in the whole code implementation.

I'm open to get help for this task to make everything integer. Will you?

roball’s picture

roball commented

Sure, I'm open as well :-)

And yes, a real secret vote is not currently possible - even if the results tab is not showed - because admins can still dig into the SQL tables (via phpMyAdmin for example).

OK, so let's keep this how it is for the moment and try to implement the new feature: #826214: Add new secret poll type.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs work » Fixed

back to fixed for now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.