* notice: Undefined index: node in sites/all/modules/block_edit/block_edit.module on line 228.
    * notice: Trying to get property of non-object in sites/all/modules/block_edit/block_edit.module on line 228.
    * notice: Undefined index: in sites/all/modules/block_edit/block_edit.module on line 228.

Please turn on verbose debugging output so in the future you can see bugs like this upfront.

Comments

jwilson3’s picture

Status: Needs review » Reviewed & tested by the community

I can confirm this error still exists with the latest versions of block_edit module (6.x-1.10) as well as with dev.

This is a trivial bug and a trivial fix reported long ago and I'm sad to see that it still hasn't made it into the codebase yet :/

jwilson3’s picture

StatusFileSize
new575 bytes

A modified patch for people using the latest recommended release (6.x-1.10)...

jwilson3’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new822 bytes

Actually, this issue is compounded if the variable 'block_edit_tabs' hasn't been set... for example, when you first install the module. The default array_keys() provided by the variable_get('block_edit_tabs', array_keys(X)) is in the wrong format.

This fixes the default variable_get() as well as the logic in the if statement.

larskleiner’s picture

StatusFileSize
new812 bytes

The OP patch does work for me in 6.x-1.x-dev, thanks eMPee584.

gmclelland’s picture

+1
original patch works for me in 6.x-1.x-dev, thanks eMPee584.

@jwilson3 - I couldn't get your patch in #3 to apply to 6.x-1.x-dev

gmclelland’s picture

For what it is worth...

Tested again with @eMPee584 patch, works but I seem to be having block_edit problems with the local task menus not showing in places like admin/build/path

Tried @jwilson3 patch again, but it didn't apply.

joelstein’s picture

Status: Needs review » Fixed

Fixed in 6.x-1.x:
http://drupal.org/commitlog/commit/7690/e466f8fcfe4d5c0004d1bc7169dd27f4...

A new release will be available shortly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.