checkbox option

I attached a patch which should operate almost exactly as described/requested above. On the webform component editing page, the newsletters selection box is now a multi-select box; by default, you can now subscribe a person to more than one newsletter using a single text entry field by selecting multiple newsletters in the component configuration. This leaves the current visitor-facing UI the same, but allows more functionality on the back end.

There is also an option to "Allow individual selection of newsletters"; this will display a list of newsletters the visitor can subscribe to as a list of checkboxes, populated from what was selected in the component editing screen, so for instance, one webform can display the option to subscribe to newsletters A, B, and C, and another webform can display the option to subscribe to X, Y, and Z.

Please review and let me know if it works out. Thanks!

Thanks for the patch hotspoons
As I don't really need this for my project, my test wouldn't be enough, let's see if the rest of people that were interested in this can test it and I will commit it.

Thanks for this patch hotspoons - it's functionality is exactly what I was looking for. Am testing it out - so far so good :-)

Thanks for the patch. Its work great.

But there is just one problem. When I submit webform it shows blank page (no thank you page). Also when you confirm your subscription it shows blank page.

The patch is working fine for me, thanks hotspoons.
The original request of this issue to have the option to have a checkbox instead of textfield for email address would be very very useful. Has anyone managed to implement this?

Hi guys,

As I'm not going to need anymore than the current code published in the project, maybe one of you wants to take care of the project (hotspoons?) and the new features required.

Let me know what you think.

subscribe (+1)

#2 works for me, but the patch didn't apply so I had to apply the changes manually.

To add the SimpleNews email address as the sender address change line 14 in "webform_simplenews.module"

from:
'email' => TRUE,

to:
'email_address' => TRUE,

Now you can use it as a 'standard' email address.

I'll take it on. I have a CVS account - what else needs to be done?

Thanks hotspoons
I've granted you access to CVS so you can commit the project!

Commited the patch by hotspoons, thanks
#11 that is commited as well in a previous patch today, thanks.
Marking this as fixed

Hi,
I'm using the Oct 4th dev version but I dont see an option to add this as a check box..I can only add an email field which gets filled in...am I missing something simple?

Thanks, Joe

duped

duped

duped

Ok, I solved my problem:

I wanted to be shown the checkboxes even if only one newsletter is available. Also I wanted to be able to customize the label for each newsletter.

What I've done so far (maybe someone can add it to a patch or whatever):

simplenews_admin.inc

I've created a new field under the name (line 154):

$form['name'] = array(
    '#type' => 'textfield',
    '#title' => t('Newsletter name'),
    '#size' => 50,
    '#maxlength' => 128,
    '#description' => t('The name of this newsletter.'),
    '#required' => TRUE,
    '#default_value' => isset($term->name) ? $term->name : '',
  );
  $form['simplenews_checkbox_label_'. $term->tid] = array(
    '#type' => 'textfield',
    '#title' => t('Checkbox Label'),
    '#size' => 60,
    '#maxlength' => 128,
    '#default_value' => variable_get('simplenews_checkbox_label_'. $term->tid, "Yes I would like to subscribe."),
  );

As you can see is a text to describe what would be the label of that newsletter if shown somewhere.

Same file, around line 290 (after the previous addition):

variable_set('simplenews_checkbox_label_'. $tid, $form_state['values']['simplenews_checkbox_label_'. $suffix]);

This will save the content of the field and can be retrieved.

Now with other file:

webform_simplenews.inc

Around line 156 changed this:

if (count($news_vid) > 1 && $component['extra']['individual_newsletter_selection']) {
    $options = array();
    foreach (taxonomy_get_tree(variable_get('simplenews_vid', '')) as $newsletter) {
      if ($news_vid[$newsletter->tid] != 0)
        $options[$newsletter->tid] = $newsletter->name;
    }

To this:

if (count($news_vid) > 0 && $component['extra']['individual_newsletter_selection']) {
    $options = array();
    foreach (taxonomy_get_tree(variable_get('simplenews_vid', '')) as $newsletter) {
      if ($news_vid[$newsletter->tid] != 0)
        $options[$newsletter->tid] = variable_get('simplenews_checkbox_label_'.$newsletter->tid, '');
    }

This will show the checkboxes if there are more than one newsletter and instead of the newsletter name will show the newsletter label previously added.

Any chance of a D7 patch? :)

What's about the initial feature request?

To get a checkbox instead of input field and the email value would be populated from the already filled in mandatory (webform) e-mail field.

Well, that is what this does for me... a checkbox. Works perfectly.

Then I must be doing something wrong!

With only one Newsletter I only get a e-mail-Field where I can enter the E.Mail-Address (already entered in an webform-e-email-field) again.

With two Newsletters I get an e-mail-Field and additional two Checkboxes (one for each newsletter).

Did you use the comment #20 code?

Maybe it's already implemented in the 6.x-Dev version...

Yes, I tried the code from comment #20.

The only thing what this code does, is to enable the checkbox even if there is only one newsletter. But it does not remove the input field for the e-mail-address.

And if you enter an e-mail-addess this address is used for the newsletter, no matter it the checkbox is checked or not.

Moreover it's not possible to get the e-mail-address from an other e-mail-field (webform).

So my result: this is not working at all!

Did you change the code as described in comment #11?

This code is already in the module:

function webform_simplenews_webform_component_info() {
  $components = array();
  $components['newsletter_email'] = array(
    'label' => t('Newsletter email'),
    'description' => t('Email for newsletter'),
    'features' => array(
      'csv' => TRUE,
      'email' => TRUE,
      'required' => TRUE,
      'conditional' => TRUE,
      'email_address' => TRUE,
      'spam_analysis' => TRUE,
    ),
    'file' => 'webform_simplenews.inc',
  );
  return $components;
}

Well, i've tried it again, and it's working fine.

Attached is the module i'm using.

You should use the newsletter e-mail field. It works just like the webform e-mail (if code from comment #11 is used). You could populate it with a token and hide it using CSS display: none if that is what you want...

How can I populate the newsletter e-mail field?

As far as I webform does not provide any tokens and the newsletter e-mail field does not have a input filed to insert a token.

I see, the Newsletter E-mail field doesn't have a field for Default value... won't be really hard to implement i think.

In your first post you write:

"the email value would be populated from the already filled in mandatory (webform) e-mail field."

But you can replace the standard Webform e-mail field (i believe that s what you are referring to with the mandatory field) with the Newsletter e-mail field and use that as the standard e-mail field (instead of the one you already had, so you can delete that one).

Or do you need other functionality? Maybe i don't understand...

I've tested your module from #30 on a new D6-Installation and this works fine, indeed! Thank You!

So it must be a version-issue, since I am using D7. Because this port was done after #14 I thought that this should also work for D7. Apparently a wrong conclusion.

The issue in D7 is - after all - that a confirmation e-mail is sent, no matter if the checkbox is checked or not.

A minor issue (even in D6) could be, that it would be nice if we could see in the results if the Checkbox was checked or not.

I will go into the code and have a look what changed between D6 and D7. But I need a few days for that, because I have to do other things first.

I haven't had the need for this module in D7. Would be great if you'd post a patch!

Kind regards, Julius

Another cool feature would be the possibility to sort the order of the newsletters.

All I had to do, was to apply the code from Checking no newsletter will subscribe to all to function _webform_submit_newsletter_email.

Now it works fine!

Could someone commit the change from #20 to the D7-branch please?

Can this or has this been patched to the d7 branch? I don't see the option of a check box for newsletters with the latest dev release?

Can this be re-opened until confirmation that it exists in D7 branch?

Greatly appreciate the work and time from the developers on this module.
This thread goes back many years through multiple builds of this module and Drupal.
Can anyone elaborate and post up-to-date and concise instructions on how to add the single checkbox feature. I have a webform and I just want to provide a single checkbox for the visitor where a checked box adds the e-mail address they submit to the list of subscribers for my Simplenews newsletter.
Thanks!