Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Now that notifications and messaging 4.x are in alpha and look to be a fairly major departure from the 2.x lines, thought I'd start playing around with them on test sites. Any idea as to whether mailcomment _should_ be 4.x compatible?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | mailcomment_newhook.patch | 5.66 KB | anav |
Comments
Comment #1
gausarts commentedSubscribing. Thanks
Comment #2
anav commentedBy converting hook_message_alter to hook_messaging_message_alter I've gotten this to work well. I'm using the following versions:
Drupal 6.16
Messaging 6.x-4.0-beta6
Notifications 6.x-4.0-beta6
Mail Comment 6.x-1.0
Mailhandler 6.x-1.10
The "glue" thing in that function I left commented out. Since I'm only using one sending method I didn't really test this over several sending methods, so I didn't want to just delete it. I also commented out the footer "View original post" because the link format didn't play well with url(), and the link already exists in the email for the original post.
I also had to change _mailcomment_get_signature() to use the email header information (rather than in the body) to get it to work.
Mailcomment 6.x-1.0 has a lot of lines with trailing spaces, which I have my editor set to remove. Maybe that should be in a separate patch, but for now those corrections are in here too.
Comment #3
anav commentedUpdating issue component/version so y'all know I stuck code in here. Thanks for looking.
Comment #4
cglusky commented@anav it's been awhile since i actively used this module, but I am coming back to it for another project. I submitted a couple patches back then that touch on the functions you are working on so am familiar with some of the issues. Here's what I can dredge up from memory (or not)...
- I can't remember the reason for the glue new line.
- The signature in the header as well as the body was a requirement for some email clients such as iphone as they had a tendency to whack the header signature info. So you need a back up in the body.
- There should have been a check for the message id in the header of the reply and if that is not found then it checks for signature in the body.
If there are issues with the url() that may be causing the issues but not sure. I hope to start building my test box out this week so I'll let you know if I come up with anything.
Thanks for getting started on the M&N 4.x changes! Marking needs work since we need to keep the backup check for the sig in the body.
Comment #5
obrienmd commentedIan, Greggles - Is anav's patch ready for prime time? My only quickly available codebases are all otherwise patched against newest -dev for another issue (file handling), so of course this patch fails against those.
Comment #6
Ian Ward commentedI think we should shoot for compatibility w/ notifs/messaging under mailcomment 2.x. I just branched for 2.x last night. I'll change the version on this issue to 2.x. Here are a few more thoughts on the 2.x version http://drupal.org/node/878448
Comment #7
obrienmd commentedCool, looking forward to all of this - it's necessary for Dane Powell and I getting some of the advanced e-mail file workflow we've been working on done in a "clean" way.
Comment #8
Ian Ward commented@anav I applied the parts of your patch that specifically address the changes in the messaging_alter hook. I'd like to handle other issues under separate tickets. I believe there are a few open issues already for 1.x that concern 2.x as well and which deal w/ things like the param getting garbled. Marking this as fixed (strictly in regards to messaging/notifs 4.x compatibility). Thanks!