Seller commission option for flate rate or percentage?

Interesting, I think this would be a good addition to Marketplace. I'm surprised no one has requested it before. If someone wants to post a patch I'll commit it sooner than later. Otherwise I'll get around to it when I do :-).

We would also need to address the issue of what to do if commission is greater than the cost (this could happen with a flat rate). Any preference for this scenario?

That seems like a reasonable approach. It should be pretty easy to implement. I'll look into it when I get a chance or when someone submits a patch. Thanks!

i'd like this feature also

I need this too. Is there maybe a workaround to achieve this because everything I tried didn't work.

Hey guys,

Having read through the above I think that a good approach would be:
1. Have an additional field for flat commission, that way % and flat could be combined - for example some banks charge you x€ for a transaction + %.
2. For the case where the sale price is smaller than the commission I think that we shouldn't disallow that, but add a setting that switches between "don't apply commission for sale prices below it" or "commission the whole amount for sale prices below.." should be easy enough to do and it should make everyone happy :)

let me see if I can come up with a quick patch :)

OK, here's a patch that does all this, but it lacks the UI.

So for example the JS auto-filler doesn't work as it seemed somewhat complicated to me to do all the calculations based on if/else and the new settings in the JS code.. any suggestions would be highly appreciated on how to achieve this!

But the main thing - what happens when you save the node with a certain price - that should work perfectly fine.

Also this is probably for a different issue, but the terminology seems to be slightly confusing here.. the "commission" should be the amount that the sales representative gets, i.e. the store.. not the sellers.. actually this shouldn't be hard to change with a nice install hook that sets the variable value to 1-current.. or do you disagree?

Cheers,
Martin

subscribe

1. I don't see the patch?

2. Agreed that the commission is confusing terminology; I too thought the store took the commission, since that's in fact what they ARE doing; taking a percentage of the sale.

is this done yet?

Wheres the patch also?

Thank you

jesus, took people 2 months to notice I forgot to attach the patch.. how long will it take to review it I don't dare to wonder :)

But anyway, here it is.. sorry for forgetting. Read http://drupal.org/node/763220#comment-3628504 for details on what is and is not in it.

Cheers

ok, i applied this patch against the dev version.

I dont notice anything though, where do I put the flat rate?

Sorry I forgot to change the version. The patch applies to the -dev version of course (though it might be slightly outdated by now).

In the same place where you usually set the commission, there should be some additional configuration fields there now, if the patch applied successfully on your server.

PS. Let's not edit our posts, as that makes the conversation flow really hard :)

sorry, I noticed it was was for the dev after I made the comment so went to edit the comment, but thought I'd try out the patch on the dev first, and left the comment open for almost an hour before I posted it.

Ok, got that bit working. Under seller settings I have, Maximum Commission Rate (Default):
and Commission Flat Rate (Default):

Ive filled in the fields but no commission gets charged.

Hey,

well there are several things to look at here:

1. As I mentioned in my comment, the commission rates will not update through JS when editing your product.

2. Did the commission work before the patch and/or do you know how to look up the commission? IIRC there is no place where you can see how much your store actually earned off a sale, but you should be able to see that the product price and product cost are differing - that's where the commission kicks in.

3. There might be some bugs in here, and unfortunately right now I don't have the time (or need) to contribute further on this.. So if anyone wants to take this further be my guest. But I have to say that this DID work for me, at least in the very simple scenario that I described above.

Cheers

Hello Arski,

Your patch works for me. However, I had to manually apply the changes, because the "mp_marketplace.admin.inc" file is now "mp_store.admin.inc" in mp_store folder. Also, there was a bug in the mp_products.module - in function mp_products_get_commission_rate($type, $user = None) ...$user = None needed to be $user = NULL. With these minor adjustments, the % and flat commissions are working for my use case. I am not using the "Waive flat rate commission...." setting.

So, thanks very much for this great patch!!

Regards,

Saurabh

woops, stupid Python None :))

fixed patch here.. note that you're not quite right about mp_marketplace and mp_store folder - in fact it's the other way around (mp_store is replaced by mp_marketplace in the latest dev)

would love it if this could be reviewed someday and committed by the devs :)

Problem! Since applying the patch, when you go to checkout to purchase a product, you eventually come to the screen where you select patent type (I've only got paypal as an option). Paypal is greyed out but selected by default as it's the only type but there is an error message at the top of the page:

warning: mysql_real_escape_string() expects parameter 1 to be string, array given in mysite/html/includes/database.mysql.inc on line 329.

You can click on review order and complete order but you are not taken to the paypal site in order to capture payment as normal. I have since disable all of the market place modules but the problem remains.

Please advise as this has now stopped my normal shop working - my own fault I understand for trying experimental modules and patches on a production site but still.

Cheers!

if you've disabled mp and are still experiencing the issue then the likelihood is the module is not responsible for your bug.

You're right! Looks like it was a problem with the mail chimp 360 module.

I am still having a problem with marketplace and this patch.

When a seller is listing a product no minimum sale price is enforced even though one has been set. Also, the 'hide additional fields' option has been set but they are all still visible when a 'seller' lists a product.

Also, looks like commission isn't working either. If a seller sells a product no commission is logged for that seller. In fact, when looking under the 'my account' section of the seller there is no 'selling' tab which should be there to list the files for sale.

I realise that this is not directly related to the patch and it's probably something I've done wrong when trying to fix my earlier problem but I'm unsure how to proceed from her to fix things.

Any and all help appreciated!

Thanks.