Size of field (like CCK Text) [#763766]

Comment	File	Size	Author
#9	date-textfield-size-763766-9.patch	3.25 KB	brad.bulger
#6	date-fix_for_763766-3.patch	4.25 KB	thekevinday
#5	date-fix_for_763766-2.patch	2.89 KB	thekevinday
#4	date-fix_for_763766-1.patch	2.8 KB	thekevinday

Comment #1

Jackl85 commented 13 April 2010 at 14:14

Title:	Provide "Size of field"	» Size of field (like CCK Text)
Assigned:	Unassigned	» Jackl85
Status:	Active	» Reviewed & tested by the community

Do it! :)

NOTE: I USE tag for color text! DO NOT COPY!!!

1. Edit file: `date/date/date_admin.inc`

In line 19 you FOUND:

    case 'save':
      return array('default_value', 'default_value_code', 'default_value2', 'default_value_code2', 'input_format', 'input_format_custom', 'increment', 'text_parts', 'year_range', 'label_position');

REPLACE WITH:

    case 'save':
      return array('default_value', 'default_value_code', 'default_value2', 'default_value_code2', 'size', 'input_format', 'input_format_custom', 'increment', 'text_parts', 'year_range', 'label_position');

In line 109 you FOUND:

  foreach ($formats as $f) {
    $options[$f] = date_format_date($now, 'custom', $f);
  }

AFTER ADD:

    $size = (isset($widget['size']) && is_numeric($widget['size'])) ? $widget['size'] : 60;
	$form['input']['size'] = array(
	  '#type' => 'textfield',
	  '#title' => t('Size of textfield'),
	  '#default_value' => $size,
	  '#element_validate' => array('_element_validate_integer_positive'),
	  '#required' => TRUE,
	);

2. Edit file: `date/date_api_elements.inc`

In line 147 you FOUND:

  $element['#tree'] = TRUE;
  $element['date']['#type'] = 'textfield';
  $element['date']['#weight'] = !empty($element['date']['#weight']) ? $element['date']['#weight'] : $element['#weight'];

AFTER ADD:

    $element['date']['#size'] =  !empty($element['date']['#size']) ? $element['date']['#size'] : $element['#field']['widget']['size'];

Log in or register to post comments

Comment #2

Jackl85 commented 14 April 2010 at 19:26

Status:

Reviewed & tested by the community

» Patch (to be ported)

Maintainers for Date: can you insert in next release?

Log in or register to post comments

Comment #3

arlinsandbulte commented 15 April 2010 at 03:59

Status:

Patch (to be ported)

» Needs work

It makes things a lot easier and quicker if someone would create a patch file...

Log in or register to post comments

Comment #4

thekevinday commented 15 April 2010 at 13:14

Status:

Needs work

» Needs review

Status	File	Size
new	date-fix_for_763766-1.patch	2.8 KB

Here is the "patch" from #1 put in the requested format.

Log in or register to post comments

Comment #5

thekevinday commented 15 April 2010 at 20:02

Status:

Needs review

» Needs work

Status	File	Size
new	date-fix_for_763766-2.patch	2.89 KB

The patch from #1 (and therefore #4) has most of the work already done, but has missed a few things.

First, the date module provides an option to use the textbox OR a select list.

To be consistent with the core select list, the size of the field cannot be provided for the cases of the select list.
I tried to fix this by wrapping the the input field in the following if condition:
<?php if (in_array($widget['type'], array('date_popup', 'date_popup_repeat'))) { ?>
I guess this part based on a few lines below where <?php if (in_array($widget['type'], array('date_select', 'date_popup', 'date_select_repeat', 'date_popup_repeat'))) { ?> can be found.
If there are any more cases that need to be handled by the mentioned if condition, please correct this patch.

Second, the use of 60 as the default length is perfectly all right. However, date already has hard-coded 20 as the value. To preserve backwards compatibility, I changed the default value from 60 to 20. The changed code looks like:
<?php $size = (isset($widget['size']) && is_numeric($widget['size'])) ? $widget['size'] : 20; ?>

Third, everything about the original patch works, except for when the size gets applied as an attribute.
I have identified the location where the immediate problem occurs to be in the file: date_popup/date_popup.module.
The function to look for is date_popup_process_date.
The affected line is: <?php '#size' => !empty($element['#size']) ? $element['#size'] : 20, ?>
If I manually change the 20 to say 30, I do notice the size of the date field to change.
What this means is that for some reason $element['#size'] is not getting populated.

I do not know why $element['#size'] is not getting populated nor what I need to do to make sure this gets populated (aside from what is already done).
Therefore, I am marking this as needs work.

Attached is the patch from #4 with the fixes for the first and second cases mentioned in this post.

Log in or register to post comments

Comment #6

thekevinday commented 16 April 2010 at 15:30

Status:

Needs work

» Needs review

Status	File	Size
new	date-fix_for_763766-3.patch	4.25 KB

Custom watchdog prints showed the the array key '#size' never was appearing in the $element array for the function date_popup_process_date in the file date_popup/date_popup.module.

However, ['#field']['widget']['size'] did appear in the $element array.

This next patch changes date_popup/date_popup.module such that
<?php '#size' => !empty($element['#size']) ? $element['#size'] : 20, ?>
is now
<?php '#size' => !empty($element['#field']['widget']['size']) ? $element['#field']['widget']['size'] : 20 ?>

With this change in place this feature works as expected.

Please Review