Check for conflicting namespaces

Thanks adorsk for this patch! Please download the Dreditor tool to review your patch above, it will highlight several issues with regards to Drupal's coding standards (tabs should be 2 spaces, and there should be no trailing space).

+++ b/rdfx.admin.inc
@@ -13,13 +13,68 @@ function rdfx_mapping_overview() {
+    // Display a warning message.
+    $output .= '<div style="color: red;">' . t("Warning: The following namespaces have conflicts:") . '</div>';

we should move this style into a css file for rdfx

Also, there is some duplicated code in rdfx_requirements(), this could possibly be moved into the same function.

Looking much better Alex!

+++ b/rdfx.admin.inc
@@ -13,13 +13,68 @@ function rdfx_mapping_overview() {
+    // Uri should be an array.
+    if (is_array($uri)) {

It's only an array if there are potential duplicates. The comment should say something like "$uri will be an array if there are duplicate namespaces for the prefix"

+++ b/rdfx.admin.inc
@@ -13,13 +13,68 @@ function rdfx_mapping_overview() {
+      // If the array has just one uri then the namespace is unique.
+      if (count($unique_uris) == 1) {
+        $unique_namespaces[$prefix] = $unique_uris[0];
+      }

I would not include the unique URIs in this logic, and leave the unique URI table as it currently is in RDFx which calls the core rdf_get_namespace() API function. This patch should just add an extra table for the conflicting namespaces, that's it :)

+++ b/rdfx.module
@@ -11,10 +11,10 @@
-}
-else {
-  define('RDF_ARC2_PATH', drupal_get_path('module', 'rdfx') . '/vendor/arc');
-}
+ }
+ else {
+   define('RDF_ARC2_PATH', drupal_get_path('module', 'rdfx') . '/vendor/arc');
+ }

I'm not sure you meant to change these lines... there are plenty of other hunks like this one which change the indentation as well.

+++ b/rdfx.module
@@ -255,13 +255,43 @@ function rdfx_requirements($phase) {
+      // Uri should be an array.
+      if (is_array($uri)) {
+
+        // If there were multiple URIs for one namespace...
+        if (count(array_unique($uri)) > 1) {

That logic is more like what I was suggesting above. And you could have one function to get the conflicting namespaces, and call it here in rdfx_requirements() and when generating the table of conflicting namespaces.

Powered by Dreditor.

Ok, last nitpicking and after that it's good to go!

+++ b/rdfx.admin.inc
@@ -8,17 +8,45 @@ function rdfx_mapping_overview() {
+  // Display a label.
+  $output .= '<div class="messages status">' . t("The following namespaces are valid") . ':' . '</div>';

I just tried this patch when I had no conflicting namespaces, and I found this message to be confusing. How about displaying this message only when it makes sense, that is to say only when there are conflicting namespaces?

+++ b/rdfx.module
@@ -255,13 +255,31 @@ function rdfx_requirements($phase) {
+    // Get conflicting namespaces.
+    $conflicting_namespaces = rdfx_get_conflicting_namespaces();
+
+    // If there were any conflicting namespaces...
+    if ($conflicting_namespaces) {

you could spare the $conflicting_namespaces variable here and just call the function in the if statement...

Powered by Dreditor.

+++ b/rdfx.admin.inc
@@ -8,17 +8,48 @@ function rdfx_mapping_overview() {
+    $output .= '<div class="messages warning">' . t("Warning: The following namespaces have conflicts") . ':' . '</div>';
+    $output .= '<div class="messages status">' . t("The following namespaces do not have conflicts") . ':' . '</div>';

While checking that patch, I found that the ending semi colon ":" looks odd inside a color box with nothing following it in the same color space. (I think it would look better without the :).

+++ b/rdfx.module
@@ -313,6 +313,54 @@ function rdfx_requirements($phase) {
+    if ( rdfx_get_conflicting_namespaces() ) {
+
+      // Add a requirement warning and break.

coding standard. no space inside the if parenthesis. remove newline too to keep code compact.

+++ b/rdfx.module
@@ -313,6 +313,54 @@ function rdfx_requirements($phase) {
+        'severity' => REQUIREMENT_WARNING,

I would rather throw an error here, since the prefixes will not be output anywhere, developers should really be aware of that as early as possible.

+++ b/rdfx.module
@@ -313,6 +313,54 @@ function rdfx_requirements($phase) {
+  // For each namespace...
+  foreach ($rdf_namespaces as $prefix => $uris) {
+
+    // If there are multiple URIs for the prefix...
+    if (is_array($uris)) {
+
+      // Consolidate identical URIs.
+      $consolidated_uris = array_unique($uris);
+
+      // If there were multiple unique URIs,
+      // then add the prefix/URI array to the list of conflicting namespaces.
+      if (count($consolidated_uris) > 1) {
+
+        $conflicting_namespaces[$prefix] = $consolidated_uris;
+      }
+    }
+  }

probably could do with less new lines here.

Thanks Alex for your patience! I've committed your patch (see commit on your user profile). http://drupalcode.org/project/rdfx.git/commit/4ca99cf