Refactor project module to use Views

nedjo - August 2, 2006 - 15:04
Project:Project
Version:5.x-1.x-dev
Component:Projects
Category:feature request
Priority:normal
Assigned:Unassigned
Status:postponed
Description

In project browsing, I unwittingly put a lot of code in there that basically emulates what Views does much better. (I hadn't looked at Views yet.) Ideally I think we'd refactor it to use the Views module. See also this issue on project issue tracking: http://drupal.org/node/76725.

#1

dww - August 2, 2006 - 17:46

see my comments in http://drupal.org/node/76725 (which apply here, too).

#2

dww - October 4, 2006 - 09:50

#3

aclight - November 27, 2007 - 12:25
Version:x.y.z» 5.x-1.x-dev
Status:active» patch (code needs work)

Here's a very rough initial stab at views enabling project.module and project_release.module.

Right now the patch just adds the field definitions and a style plugin for displaying project overviews in a similar manner to how we display them now.

If it weren't for releases, this might be pretty close to finished. But I haven't figured out a good way to filter project nodes by whether there are any release nodes of a certain version associated with a given project. I'll take a crack at this when I get a chance, if someone doesn't beat me to it.

AttachmentSize
project-views-76726-3.patch12.55 KB

#4

hass - March 8, 2008 - 22:27

There are some translatable strings inside this patch like t('The project\'s homepage.'). This is not correct and should be fixed. It should look like t("The project's homepage.") if you have a single quote inside a translatable string. thx,

#5

aclight - March 8, 2008 - 22:28

@hass: You are more than welcome to reroll the patch.

#6

mikehostetler - March 10, 2008 - 01:12
Status:patch (code needs work)» patch (code needs review)

I've re-rolled the patch with the backslash-single quotes removed from the strings that hass mentioned above.

AttachmentSize
project-views-76726-4.patch12.53 KB

#7

aclight - April 2, 2008 - 02:53
Status:patch (code needs review)» patch (code needs work)

Reroll to remove offset and fuzz. I think this also still needs work, so setting status back to CNW.

AttachmentSize
project-views-76726-7.patch12.7 KB

#8

aclight - April 11, 2008 - 00:21
Status:patch (code needs work)» postponed

My understanding is that this is postponed for now and will be done as part of the port of the project module for Drupal 6. See http://groups.drupal.org/node/9500 for more information.

#9

aclight - April 28, 2008 - 15:20
Title:Refactor to use Views» Refactor project module to use Views

Changing title so that when this issue is linked in other issues it's obvious which module this is for.

 
 

Drupal is a registered trademark of Dries Buytaert.