Only imports the first feed item [#769084]

I am using the feeds module to import the following feed found at http://pipes.yahoo.com/pipes/pipe.run?_id=LHZmGv0d3hG9S6iXPm7D0g&_render...

The problem is that only the first item in the feed list is imported. I am wondering if the problem might be related to the guid field. The guid field has an attribute set but does not contain a URL for its value. Below is a dump of the RSS feed contents...

<?xml version="1.0"?>

STFC-NERC
Pipes Output

http://pipes.yahoo.com/pipes/pipe.info?_id=LHZmGv0d3hG9S6iXPm7D0g Mon, 12 Apr 2010 15:42:57 +0000 http://pipes.yahoo.com/pipes/

Announcement of Opportunity: Ocean Acidification - Head of Science Co-ordination

http://www.nerc.ac.uk/funding/news/outstanding.asp NERC is seeking to appoint a part time Head of Science Co-ordination to lead a team working on the UK Ocean Acidification Research Programme., The closing date is 12 Apr 2010, The closing date is 12 Apr 2010

Announcement of Opportunity: Network of Sensors

http://www.nerc.ac.uk/funding/news/outstanding.asp NERC invites outline proposals for three-year collaborative research projects that will constitute the Networks of Sensors - Demonstration High Resolution Networks research programme., The closing date is 15 Apr 2010, The closing date is 15 Apr 2010

Invitation to Tender - Identifying uncertainties in Arctic climate predictions http://www.nerc.ac.uk/funding/news/outstanding.asp The Arctic research programme invites tenders for a five month project to identify the processes/feedbacks which contribute to the range of uncertainty in future Arctic climate predictions., The closing date is 16 Apr 2010, The closing date is 16 Apr 2010

Science to Policy interactions workshop for NERC researchers and/or BES members http://www.nerc.ac.uk/funding/news/outstanding.asp

The next NERC/BES jointly funded workshop, with an LWEC theme, will take place on 18-19 May 2010 at the Defra Innovation Centre, Reading., The closing date is 16 Apr 2010, The closing date is 16 Apr 2010

Announcement of Opportunity: Joint Weather and Climate Research Programme (JWCRP)

http://www.nerc.ac.uk/funding/news/outstanding.asp Proposals are invited for two projects, to contribute to the development of strategic science areas covered by JWCRP., The closing date is 11 May 2010, The closing date is 11 May 2010

Comment	File	Size	Author
#1	feeds.patch	513 bytes	itchy

Comments

Comment #1

itchy commented 20 April 2010 at 10:53

Status	File	Size
new	feeds.patch	513 bytes

I found a solution to this problem. The problem is that the RSS feed includes guid tags that have an empty text value. All the items for the RSS feeds are parsed OK. Although the guid field which is set to URL value by default is then overwritten by the empty guid text. Therefore when it comes to updating the feed items in FeedsNodeProcessor::process() the call to FeedsNodeProcessor::existingItemId() always returns the node ID for the first item. This is because all guid fields for feed items belonging to this feed have empty values and therefore they do not have unique values.

I have included a patch where the feed parser checks to see if the guid value is greater than zero in length before overwriting the default value which is the URL.

Comment #2

XiaN Vizjereij commented 27 April 2010 at 20:38

Status:

Active

» Needs review

Comment #3

alex_b commented 27 April 2010 at 23:34

Status:

Needs review

» Needs work

Please use empty() instead of strlen()...

Comment #4

drubytue commented 3 January 2011 at 00:58

Thanks, solution worked for me. Patch is for the common_syndication_parser.inc file in the feeds/ibraries folder.

Comment #5

wikki boy 03 commented 15 June 2011 at 22:14

Version:	6.x-1.0-alpha14	» 6.x-1.0-beta10
Priority:	Normal	» Critical
Status:	Needs work	» Active

Same issue produced for me. I used similar pipe and it only imports first item and skips rest.
I have even tried the patch provided but that did'nt work for me.

I even tried importing items using this pipe http://pipes.yahoo.com/pipes/pipe.run?_id=LHZmGv0d3hG9S6iXPm7D0g&_render...
but same result only first item imports.

Please help asap if possible as my work is suffering because of this issue.

Thanks in advance!
Wikkiboy