CVS edit link for ygerasimov

Hello,

I have developed module that integrate jcarousel and imagefield. Module creates cck formatters to show images in jCarousel (rather then list of images) in the node.

Best regards,
Yuriy Gerasimov

CommentFileSizeAuthor
#16 role_ownership.tar_.gz3.45 KBygerasimov
#15 role_ownership.tar_.gz1.63 KBygerasimov
#14 role_ownership.tar_.gz1.57 KBygerasimov
#1 imagefield_jcarousel.tar_.gz1.11 KBygerasimov

Comments

ygerasimov’s picture

ygerasimov commented
StatusFileSize
new imagefield_jcarousel.tar_.gz1.11 KB
ygerasimov’s picture

ygerasimov commented
Status: Postponed (maintainer needs more info) » Needs review
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Postponed (maintainer needs more info)

Why can't you contribute that feature to an existing module that integrates jcarousel?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs work

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

ygerasimov’s picture

ygerasimov commented

This module depends on jcarousel module, so it doesn't add jCarousel javascript itself.

Features of this module are very simple: On display of the node with cck imagefield field it adds "jCarousel _imagecache_preset_name_" formatters.

After one of these formatters are used jCarousel is displayed in node view.

Regarding existing modules. I have found module jqgalview that probably does this functionality, but this module has never been released and I am not sure if maintainer have plans to develop it.

Also similar module is cck_multiple_formatter (as my module also overrides default display from blocks to unordered list), but I don't think it is nice idea to intigrate jCarousel functionality in that module, and also my module works with imagecache that is not needed in cck_multiple_formatter at all.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

This module depends on jcarousel module, so it doesn't add jCarousel javascript itself.

Why didn't you open a feature request for the features that are missing in jCarousel?

ygerasimov’s picture

ygerasimov commented

Module jcarousel 'just adds' javascript and add theme function to display jcarousel. It has nothing to do with images, cck? So I this is why I think this functionality should be separate module that 'depends' on jcarousel module.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Thanks for your reply.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Well, it could be a sub-module that ships with the project...?

ygerasimov’s picture

ygerasimov commented

please recommend to what project this can be implemented as sub-module?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Well, one of the existing.

Either http://drupal.org/project/jcarousel

or http://drupal.org/project/viewscarousel

or one of the others. Unfortunately, we already have total duplication in this area. That's why I don't really want to approve this application.

ygerasimov’s picture

ygerasimov commented
Status: Needs review » Closed (won't fix)
ygerasimov’s picture

ygerasimov commented
Status: Closed (won't fix) » Closed (fixed)
ygerasimov’s picture

ygerasimov commented
Status: Closed (fixed) » Needs review
StatusFileSize
new role_ownership.tar_.gz1.57 KB

Hi,

I have developed node access module that gives full access rights to selected role. When user creates/edit the node he can select the role (one of roles that he is in). It works like user gives ownership to the group he is in. Also users can pass the ownership to different groups. But at any time there is only one group that has full rights to the node.

Settings page let administrator to select to what node types this kind of access rules can apply.

Please review http://drupal.org/node/268100#comment-875260 to see that my module is different to the ones that have already been created.

There were also discussion about such functionality on http://drupal.org/node/552296 but no solution were found.

ygerasimov’s picture

ygerasimov commented
StatusFileSize
new role_ownership.tar_.gz1.63 KB

code of the module cleaned with coder

ygerasimov’s picture

ygerasimov commented
StatusFileSize
new role_ownership.tar_.gz3.45 KB

Module has been updated. New functionality (logging) has been added as separate submodule.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

I am approving the application basing on the code attached to comment #15.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes