Add webform components on translation.module duplication

Well there's some general i18n support task which i didn't realize before.
#245424: Make Webform multilingual (i18n) aware through contributed modules

Still leaving this issue here for the moment.

Further notes about how to solve this.. not tested yet.

Note this is support for content translation (translation.module) from core. I18n only improves the situation (and is state of the art), but in general this sequence is directly core support.

function webform_node_insert($node) {
...
  // add components from translation source
  if (!empty($node->translation_source)) {
    if ($node->translation_source->tnid) {
      $node_src = node_load($node->translation_source->tnid);
      // saving everything that is not in the primary node form here.
      if (isset($node_src->webform['components']) && !empty($node_src->webform['components'])) {
        foreach ($node_src->webform['components'] as $cid => $component) {
          $component['nid'] = $node->nid; // Required for translation.module.
          webform_component_insert($component);
        }
      }
    }
  }
...
}

I think this would work pretty well. Any objections to this approach?

Providing patch.
Tested and works. Please review and include in 3.x-dev.
Changing title to make it match core translation.module. However this is also core base for i18n.

quicksketch, this is a new feature. There was no translation support in 2.x.

Checked plain installation of drupal (node+translation.module) with i18n and webform in 2.9 (current revisions):
You need to do the following to check the situation:
- Enable "Content translation"
- Add at least 2 languages
- Switch Content type webform to Workflow "Multilanguage enabled, with translation"
- Add a webform with components
After adding a node translation, components are lost.

This is because the components are not part of $form and there's no invocation to apply the components / elements from origin $node (translation source) to the final translated node. Indeed we're missing a hook here, but i'm not yet sure what would be the best name / definition of it.

For the current 3.x dev webform we have the same situation.

This patch adds the new feature of adding elements to the new $node which are not in $form as a first step.
Further modifications of the elements are possible, nothing will be synced, on further steps users can modify fields freely.
There's a lot of additional work for advanced translation support, see #245424: Make Webform multilingual (i18n) aware through contributed modules
But it's already nice to see them available as a first step.

To follow this whole process i'm missing some details.
I don't understand why "webform_node_update" on update currently needs to check for existence of $node->nid and switch to insert if not. Sounds like some edge case where invocation was a bug or weight of node resaves (insert + update) within a single cycle leads to a twisted sequence (update+insert) invocation...
So it's a workaround?

You're quoting the _update function. Note that we're talking about the insert case.

Note that the only nodeapi things that happen are: validate, presave, save - leading to webform_node_insert with present translation_source. The $form['webform']['component'] part is empty for all cases.

Already on the node add form (reached from "add translation") we're encountering a webform array with empty components.

Note that cloning a node is somewhat different from making translation duplicates. Regular clones are always separated, while translation dupes have some entanglement (which not yet happens here on a component basis) in most cases...

quicksketch, any further inputs about your ideas?

OK, understood.

Attached patch provides the tested result when following your example.
Swapping array and object style, switching tnid to nid (since translation_source is the $node of the source/origin).

At least in this clean drupal+i18n+webform 3.x checkout it works neat.

Thanks for your inputs. Please review again.

But there's a big oops now.

We're overwriting the node->webform part. This means, if some form part is on the node edit form, we're overwriting something with original/untranslated content that might be edited by the user.

You're also right since the $node object now is in invalid state - it doesn't represent the saved state. Doing another node_save to resave the node will write different values. (Some tools like rules.module do that on one single node save after triggering rulebased changes.)

The node cloning should happen before the nodeapi validate thing happens. I think it should even happen before node validate occurs.

Checking the translation.module implementation of nodeapi which finally invokes this after loading the node:

node_invoke_nodeapi($node, 'prepare translation');

I think i've found the right direction with implementing this hook. My forms cleanly copy now and the webform values can be overridden in the drupal standard form / submit / save process.

Is there any compareable situation from a different module?

Thanks for review Eugen. Hope this remains self-explanatory and fast forward.