Here's a start, I plan to move the createProject method to a separate class and have all the test* methods live in classes that extend ProjectTestCase.

CommentFileSizeAuthor
#11 774706-project-tests-11.patch1.9 KBmikey_p
#8 774706-8.project_test.patch4.63 KBdww
#7 project_tests-7.patch4.4 KBmikey_p
#4 project_tests-4.patch4.82 KBmikey_p
#2 project_tests-1.patch432 bytesmikey_p
project_tests.patch4.32 KBmikey_p

Comments

dww’s picture

dww
we/he/they
commented

A few related efforts:
#279515-29: setting an installation profile for a test doesn't run hook_install_tasks()

There's also a bunch of Project*-related setup code in some tests for PIFT:
http://drupalcode.org/viewvc/drupal/contributions/modules/project_issue_...
http://drupalcode.org/viewvc/drupal/contributions/modules/project_issue_...

mikey_p’s picture

mikey_p commented
Status: Active » Needs work
StatusFileSize
new project_tests-1.patch432 bytes

Here's a follow up to move the abstracted stuff such as createProject to ProjectWebTestCase, so that ProjectTestCase and ProjectIssueTestCase can extend a common class where we can stash basic functionality (like createProject).

dww’s picture

dww
we/he/they
commented

@mikey_p: wrong patch. ;)

mikey_p’s picture

mikey_p commented
StatusFileSize
new project_tests-4.patch4.82 KB

Yes :(

dww’s picture

dww
we/he/they
commented

great start, thanks! a few questions:

A) WTF?

+    call_user_func_array(array($this, 'parent::setUp'), $modules);

Why not just:

+   parent::setUp($modules);

?

B) What's up with the patch against project.js? ;)

Thanks!
-Derek

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

D6 simpletest's setUp() doesn't accept only one parameter for an array of modules, that's why cufa() is needed since it needs to pass each module name as a separate parameter.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review
StatusFileSize
new project_tests-7.patch4.4 KB

Sorry about the mixup with project.js (it's not *that* wrong). Part of my notes from #371957: Add customized per project type related vocabularies were included.

This is passing for me.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed
StatusFileSize
new 774706-8.project_test.patch4.63 KB

Ran locally myself and saw all assertions pass, yay! Fixed some comments (see attached patch), and committed to HEAD.

YAY!!!

grendzy’s picture

grendzy commented

more tests at #775052: Automated tests for project_release module

dww’s picture

dww
we/he/they
commented
Component: Projects » Tests

For posterity. ;)

mikey_p’s picture

mikey_p commented
Status: Fixed » Needs review
StatusFileSize
new 774706-project-tests-11.patch1.9 KB

It'd be good to have a standard pattern for this, updating project.test to match #776128: Add tests for issue creation (including metadata fields).

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Yup, totally agreed. Ran tests locally and got all passes. Code looks good. Not going to wait for the bot -- committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.