Closed (fixed)
Project:
Islamic Prayer Times
Component:
Miscellaneous
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
18 Apr 2010 at 18:35 UTC
Updated:
31 Mar 2011 at 07:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
mohammed j. razemA dev version will be released within 1 month inshaAllah. As we as we produce a functional code.
I'll close this issue once a dev snapshot is released to inform you.
Comment #2
edubuc commentedSalaam,
Thanks for developping this module, it will be useful insha'allah
Baraka allahou fik
Comment #3
good_man commentedAny news or updates?
Comment #4
zirko19 commentedSalaam.
Thank you for developing this module. Can I use it for my research later?
Comment #5
cssdru commentedHello / Salam
Please, any update?
Regards,
Comment #6
a.ross commentedI am interested in this module. Since the maintainer seems absent, I will see what I can do with the code that is in CVS now. Stay tuned brothers
Comment #7
a.ross commentedCode in CVS is almost useless at this point. They were in the progress of porting a JS file for calculating prayer times to PHP. I'll start from scratch, also because I need to learn how to write modules.
Comment #8
good_man commented@a.ross, just FYI, you can request to maintain this project instead of opening new one.
Comment #9
a.ross commentedYes I know, but I already started working on a module from scratch which already offers basic functionality.
Have you seen what's in CVS right now? It's close to nothing ;)
Comment #10
cssdru commentedHello,
Unfortunately, nothing happens when I install the code in CVS! I wondered if I am missing something..
It would be great to have a module ready for use!
Thank you in advance,
Comment #11
a.ross commented@cssdru
I am working on a new module with this functionality. Am busy writing the astronomic calculations right now, which is pretty hard since I don't know anything about astronomy. Fortunately I know something about trigonometry :)
My script is almost done and I will submit it to Drupal soon! I expect it to be done this week. Don't expect anything fancy just yet, I still need to figure out how to use Drupal's theme layer amongst some other things.
However, a quick list of features I have in mind:
* Automatically determine location of visitor (by using another module) [DONE]
* Calculate times (of course) [DONE]
* High latitudes (north/south pole) problem [IN PROGRESS]
* Qibla direction [DONE]
* Sun direction [DONE]
* Moon direction [DONE]
* Compass displaying directions [DONE]
* Adhan playing on client side
* Calendar
I hope it will be useful
Comment #12
sadist commentedYour list of plans seems promising. It eventually becomes a set of suite instead of just a module. Please let me know how I can help and get my hands involved in the project.
Comment #13
a.ross commentedThanks! I am now in the process of requesting developer access, see #1025576: a.ross [aross1]. I hope they will grant me access, then it will be easy for others to join in the development and the community can do some testing.
Comment #14
rodmarasi commentedcounting on you. subscribing.
Comment #15
cssdru commented+
@a.ross
More than useful..Thank you very much in advance.
Comment #16
Monzer Emam commentedHi All,
@a.ross: thank you for your work.
Attached is a initial working copy of @a.ross adhan module with some modifications to work with D7.
PS: Currently location is hard coded in 'adhan.module' lines 43,44,45 to change them to other location please refer to http://www.travelmath.com/country/Kuwait to get your city values as
line 43 '$lat = 29.3375;' is for Latitude
line 44 '$long = 47.6581;' is for Longitude
line 45 '$zone = 2;' is for GMT time zone for ex: Kuwait is +2 so the $zone value is set to 2.
also rename the file to 'adhan-7.x-0.1.tar.gz'
In near future I will work on theming it drupal way,Adding block from settings page,find your city from settings page(no need to get the values manual way).
Comment #17
a.ross commentedHey, nice to see some action here. Be warned, many things are not working yet. I want to have a fully functional version done of the calculation algorithm this week and I want to reorganize the module's code and make it theme-able. Please hold your work on the D7 port because a number of important features are on it's way. I've already managed to resolve the visitors location using the Smart IP module, so the visitors location is used to display his prayer times.
I will try to keep status somewhat up-to-date here: http://drupal.org/node/774712#comment-3932150
At the end of the week I will upload another snapshot.
Comment #18
Monzer Emam commentedOk, I will wait,But IMHO we can on different areas at same time.
Comment #19
a.ross commentedI have had a reply here: #1025576: a.ross [aross1]. Let's wait and see how that progresses, it will be better if we have a project here on Drupal, than developing through this thread. Things will get mixed up and nobody can file issues etc. If it doesn't go as quick as we'd hoped, I will set up a project on my homepage and I might even set up a git server at home. But I'd like to avoid all that so I hope I will get CVS access soon :)
Comment #20
hasnainj commentedSubscribe
Comment #21
Monzer Emam commentedno need to a git server at your home, we can host it on code.google.com for now.
and issues also can be discussed on google.com until moved here.
Comment #22
a.ross commentedThat's a good idea, I just hope it's not necessary. I probably still have to set up a git server though for other projects of mine and I already have a web server at home, so that won't be a lot of work. We'll see how my application goes, I'll give it at least until februari
Comment #23
a.ross commentedNew version of my module upoaded, now using theme layer (default template is incomplete though) and a lot of work done in the calculation algorithm. Still quite some work to do. If I don't get a reply on my application until februari, I will make a project on Github or the like.
Feature list updated
Comment #24
a.ross commentedAs promised, I setup a project page here. Yes I'm stubborn, but I wouldn't be me if I wasn't :)
Issues will be discussed on my homepage.
Comment #25
sadist commentedhi ross,
from the page, you stated that the auto detect of visitor's location has already been done. but the adhan prayer time that is being displayed is wrong from where I am now, which is Singapore.
Comment #26
a.ross commentedI prefer to discuss these issues on my homepage. But I suspect you either didn't install the Smart IP module (on which adhan depends to detect location) or you haven't set it up properly and your browser doesn't send location info. If you have installed Smart IP, you should get a bar in the top of your browser asking to send location info. AFAIK this works with Firefox and Chrome.
Smart IP will detect your location based on your IP address if your browser doesn't support sending location info.
My module just runs without checking for Smart IP. This is an issue and will be resolved in the future. Could you please make an account at my homepage? www.amdev.eu
Comment #27
good_man commenteda.ross: issues should be better here to discuss, review and provide patches, and let's keep this issue for one thing only which is what the title says, after you get the maintainer ship we can open other issues instead of overflowing them here.
Comment #28
a.ross commentedThe thing is, when will I get access? I have seen a lot of applications pending for a long time, so I'm not so sure I will get developer access soon. This is why I asked to go to my site and discuss issues there, which is much more convenient than in this thread.
Unless you want to abuse this module's space. But I didn't request maintainership of this module.
Comment #29
a.ross commentedoops status changed :)
Comment #30
mohammed j. razemSorry for I have been pretty busy this period, and couldn't bring the required attention for this issue.
@a.ross I'd love to add you to module maintainers, but seams like you don't have CVS access.... Can we have a plan to merge your efforts and maintain a robust module? Would you apply for a CVS access?
Comment #31
a.ross commentedI see you've found my application already :) good to finally hear from you though! You think we should have a chat on merging?
Comment #32
good_man commentedCan we close this issue now as you have access now and open another one for merging?
Comment #33
a.ross commentedI don't have access... doublethink is not a CVS admin.
Comment #34
mohammed j. razemUntil a.ross gets the CVS access, or maybe Git access! We'll open a new issue to discuss the merging, and probably having a submodule "Adhan" to call for Adhan with different voices. Check out the "Guidance" app for Mac for what I mean.
Comment #35
hasnainj commentedI was just wondering what was the progress on this and how can I use this module? Is there anything that I do to help you guys speed up the release of this module? I am happy to help you out.
Comment #36
a.ross commentedModule already works, check http://amdev.eu/project/adhan you can download it from there for the time being.
It's not feature complete, but it works.
Comment #37
ayalsule commentedSubscribe
Comment #38
sadist commentedhi ross. from your project site,
1) instead of using the plugins, isn't there any other better ways to detect the user's location? like most used for banner ads or some sites that detects user's location to forward them to it's local site.
2) even after I'd allowed the plugin using my Google Chrome, it still shows the wrong time.
Comment #39
good_man commented@a.ross can you join the #drupal-contribute channel on IRC to speed up the process of granting you access, so others can really create new issues instead of overflowing this one?
Comment #40
a.ross commentedThe plugin can detect location the "right" way, by using W3C coordinates, but if it fails, it will resolve the visitor's IP address. Detecting someone's country definitely isn't accurate enough. Many sites do this by using the locale setting of the browser (which I've set to US, although I'm in Europe).
By the way, after allowing, you might need to refresh the page. If it still shows the wrong time, you can register om my site and submit an issue.
@good_man, I've tried on IRC twice before, but I will try again. Most likely we will have to wait for GIT though. (Almost there).
Comment #41
good_man commentedyeah think so too, with git it'll be so easier, it's very close so a little waiting won't hurt now.
Comment #42
a.ross commentedI have progressed a lot. Please have a look at my homepage http://www.amdev.eu/en/project/adhan
Have a look at the qibla compass and tell me what you think ;)
There's a link on that page to my GIT server, where you can download the module in it's current status.
Comment #43
a.ross commentedNew additions are automatic refresh of the timetable and even a notification dialog with adhan playing in it :)
I've set up a sandbox project here on Drupal.org at this page: http://drupal.org/sandbox/a.ross/1073408
I like git. I will apply for a full project and see what happens.
Comment #44
sadist commentedHi ross,
I'd tried your site with a few browsers and all still displaying the wrong timing, not even close. I attached 3 screenshots, 1 is being before I allow the plugin, 2 is once allowed and 3 is the correct time for my location that I captured from islamicfinder.org
Comment #45
a.ross commentedIf you look closely, you will see that the time differences between prayers are correct! Now, if you register an account on my page and set your timezone correctly (GMT+8, correct?) the times will be shown correctly. This is because Drupal has no way of knowing what time zone an anonymous visitor is in. In that case it will use the sites default time offset (in my case GMT+1, which causes the 7 hours difference).
I am using another module to determine visitors location and in the future that module will also offer determining the timezone. Here is the issue: #1030212: Add identification of user's timezone
This is NOT an issue with my module. But, in stead of posting your issues here, please post issues in my sandbox project here: http://drupal.org/sandbox/a.ross/1073408
EDIT: I have created a patch for that module and you can find it in the above issue. I applied it at my site and it should display times in the correct timezone now. Please test and let's discuss further on my sandbox page. http://drupal.org/sandbox/a.ross/1073408
Comment #46
a.ross commentedMy application has been approved and you can find my project here:
http://drupal.org/project/adhan
I also hope to have a fully functional port of it to Drupal 7 by the end of this month.
Comment #47
ANUWerkz commentedNice.. will test it soon