Error when loading via an installation profile

I tested this patch and it fixes the problem of the error on install via install profile. Probably could use another set of eyes but for now I'll mark as reviewed and tested.

This part of the patch seems to be problematic:

- drupal_load('module', 'url_alter');
+ // Don't load try to load the module during installation.
+ if (!defined('MAINTENANCE_MODE') && constant('MAINTENANCE_MODE') != 'install') {
+ drupal_load('module', 'url_alter');
+ }
+

After install via install profile (success!) the code above spits out an error when hook_requirements() gets invoked.

error was:

Warning: constant() [<a href='function.constant'>function.constant</a>]: Couldn't find constant MAINTENANCE_MODE in url_alter_requirements() (line 35 of /opt/www/tng-fresh/sites/all/modules/contrib/url_alter/url_alter.install).

I presume that the problem is simply that the !defined('MAINTENANCE_MODE') should be defined('MAINTENANCE_MODE') as if the first is TRUE and then you invoke constant() you will get a PHP error.

Attached a patch of patch to flip the negation. Hopefully that results in intended behaviour.

Hi

we had the same problem while running a dupal_make script and needed the patch. I believe jaydub is correct that the if shouldn't be !.
Otherwise this patch fixed a WSOD on install.

I did a few changes to the patch:

+++ url_alter.install	19 Apr 2010 16:27:40 -0000
@@ -31,19 +31,43 @@ function url_alter_requirements($phase) 
+  // Don't load try to load the module during installation.

Removed typo.

+++ url_alter.install	19 Apr 2010 16:27:40 -0000
@@ -31,19 +31,43 @@ function url_alter_requirements($phase) 
+  if (defined('MAINTENANCE_MODE') && constant('MAINTENANCE_MODE') != 'install') {

Changed to !== because the constant is a string and we should avoid uneccessary type checks.

+++ url_alter.install	19 Apr 2010 16:27:40 -0000
@@ -31,19 +31,43 @@ function url_alter_requirements($phase) 
+  ¶

Space after line end.

+++ url_alter.install	19 Apr 2010 16:27:40 -0000
@@ -31,19 +31,43 @@ function url_alter_requirements($phase) 
+    if (defined('MAINTENANCE_MODE') && constant('MAINTENANCE_MODE') == 'install') {

Changed == to === typed check.

+++ url_alter.install	19 Apr 2010 16:27:40 -0000
@@ -31,19 +31,43 @@ function url_alter_requirements($phase) 
+    // During normal usage

Comments should have a . at the end.

Powered by Dreditor.

Can we just make it easier and skip the requirements check if MAINTENANCE_MODE = install?

The patch in #8 resolves for me both the issue with enabling via install profile as well as an issue with regular install at /admin/build/modules after using patch in #4 (problem with url_alter_is_disabled() not being defined yes but used in hook_requirements which is called into play on install).

Patch in #8 did not apply cleanly to 6.x-1.2. Re-rolled patch attached.

Patch in #10 resolves the issue for me. Marking RTBC since it was a simple re-roll of #8. Also setting to major, as it really affects installation profiles.

#10 worked for me.

Yes,#10 solved the problem

Patch needs to be applied to dev version or else causes fatal errors as url_alter_is_disabled doesn't exist in 1.2, but does in dev and patch uses it.

@hefox covered it.