After upgrading from beta2 to version 2.0 it saves fields from "Advanced options" of SingleFrame mode like this:
"field: value\nfield2: value" instead of "field: value", "field2: value" (see view source of js code generated)

CommentFileSizeAuthor
#8 777990-isnumeric-1.patch1.63 KBredndahead
#7 views_slideshow_js.patch772 bytesalexromao

Comments

redndahead’s picture

redndahead commented

that's how it should look what problem are you having?

redndahead’s picture

redndahead commented
Status: Active » Postponed (maintainer needs more info)
redndahead’s picture

redndahead commented
Status: Postponed (maintainer needs more info) » Fixed

Marking as fixed

alexromao’s picture

alexromao commented
Status: Fixed » Active

I got the same problem after the upgrade to Slideshow 2.0.
On FF 3.6 only the first parameter set on the "Advanced options" box is working, all other parameters are ignored.
On IE 8 no paramter set will work.

redndahead’s picture

redndahead commented

Can you first upgrade to 2.1 and then if possible link to a site that is having the problem or send me the settings javascript output that can be found in the source of your page?

redndahead’s picture

redndahead commented
Status: Active » Postponed (maintainer needs more info)
alexromao’s picture

alexromao commented
StatusFileSize
new views_slideshow_js.patch772 bytes

Hi,

sorry for the late response.

I've managed to fix the problem which seemed to be an iteration variable that got overwritten in the
views_slideshow.js file (calling the IsNumeric() function).

This was the primary cause for a for loop just executing 1 iteration only, and all other additional
advanced parameters where just ignored.

here is a patch to fix this problem.

redndahead’s picture

redndahead commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 777990-isnumeric-1.patch1.63 KB

Thanks L3X that was a good catch. I changed the patch up to declare the variable in the function so that it is local. Can you please test the attached patch.

alexromao’s picture

alexromao commented

Hi,

I've tested the patch and it works just fine.
For both Slide shows, singlefram- and thumbnailhover-slideshow.
I'd say it's fixed.

redndahead’s picture

redndahead commented
Status: Needs review » Fixed

this has been committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.