Download & Extend
Views Slideshow » Issues

Advanced settings not workin

Posted by gabrielu on April 21, 2010 at 9:39pm
Project:Views Slideshow
Version:6.x-2.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

After upgrading from beta2 to version 2.0 it saves fields from "Advanced options" of SingleFrame mode like this:
"field: value\nfield2: value" instead of "field: value", "field2: value" (see view source of js code generated)

Login or register to post comments

Comments

#1

Posted by redndahead on April 22, 2010 at 3:49am

that's how it should look what problem are you having?

#2

Posted by redndahead on April 27, 2010 at 6:48pm
Status:active» postponed (maintainer needs more info)

#3

Posted by redndahead on May 12, 2010 at 8:27pm
Status:postponed (maintainer needs more info)» fixed

Marking as fixed

#4

Posted by alexromao on May 21, 2010 at 9:38am
Status:fixed» active

I got the same problem after the upgrade to Slideshow 2.0.
On FF 3.6 only the first parameter set on the "Advanced options" box is working, all other parameters are ignored.
On IE 8 no paramter set will work.

#5

Posted by redndahead on May 21, 2010 at 3:00pm

Can you first upgrade to 2.1 and then if possible link to a site that is having the problem or send me the settings javascript output that can be found in the source of your page?

#6

Posted by redndahead on May 21, 2010 at 3:01pm
Status:active» postponed (maintainer needs more info)

#7

Posted by alexromao on May 28, 2010 at 1:20pm

Hi,

sorry for the late response.

I've managed to fix the problem which seemed to be an iteration variable that got overwritten in the
views_slideshow.js file (calling the IsNumeric() function).

This was the primary cause for a for loop just executing 1 iteration only, and all other additional
advanced parameters where just ignored.

here is a patch to fix this problem.

AttachmentSize
views_slideshow_js.patch 772 bytes

#8

Posted by redndahead on May 28, 2010 at 4:57pm
Status:postponed (maintainer needs more info)» needs review

Thanks L3X that was a good catch. I changed the patch up to declare the variable in the function so that it is local. Can you please test the attached patch.

AttachmentSize
777990-isnumeric-1.patch 1.63 KB

#9

Posted by alexromao on June 1, 2010 at 9:35am

Hi,

I've tested the patch and it works just fine.
For both Slide shows, singlefram- and thumbnailhover-slideshow.
I'd say it's fixed.

#10

Posted by redndahead on June 4, 2010 at 3:48am
Status:needs review» fixed

this has been committed.

#11

Posted by System Message on June 18, 2010 at 3:50am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.