Closed (fixed)
Project:
Views Infinite Pager
Version:
6.x-0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Apr 2010 at 00:45 UTC
Updated:
6 Feb 2011 at 01:16 UTC
Jump to comment: Most recent
Comments
Comment #1
thebuckst0p commentedThat's cool.
3 questions/notes:
1) That's only for Views 3, the code I wrote was meant for Views 2, are you planning a backport?
2) Yours loads the next page automatically, mine with a manual More button, though toggling one to the other is probably not difficult.
3) Do you want to put yours on drupal.org? We can make 2 branches, one yours for D7/Views3 and one for my D6 version, if you're interested in that.
Comment #2
youkho commentedWould be great to be able to choose loading options "automaticly or manualy"
Comment #3
cerup commentedNice cjdavis, but the code isn't finished because it's not a full implementation and it's not hosted on drupal.
I agree with thebuckst0p:
1) There has to be a views 2 version (either backported) or in conjunction with thebuckst0p's work.
2) There has to be a manual option. There's a lot of usability issues with automatically loading more and it's a bad user experience in most cases (thus why twitter, facebook, mahalo, etc) have limitations on this.
3) It has to work with more than just unformatted views.
It's definitely a great start though!!
Comment #4
pribeh commentedsubscribing.
Comment #5
mattiasj commentedsubscribing
Comment #6
ckngAgreed with #3, those options are necessary.
1) Views 3 might not see the light as it is meant for multigroup support
Comment #7
jerodfritz commentedThanks for the feedback. I agree the interaction should be manual by default with the option for for automatic. I'll add an option to the pager style for that and add support for more than unformatted.
Comment #8
cerup commentedThanks jerodfritz.
It would be great if you can coordinate (if you're not already) with thebuckst0p so you don' both reinvent the wheel. Do you have plans to backport to Views 2?
Personally I wouldn't be able to test anything unless there's a views 2 option.
Keep up the good work.
Comment #9
saltcod commentedArrrrghh!!!!! YES!!! i've been looking for something like this. Excellent work.
Comment #10
jerodfritz commentedI added support for for the 3 other default styles in addition to unformatted and provided a manual versus automatic configuration option.
Comment #11
pribeh commentedHi cjdavis and jerodfritz,
Thanks so much for responding and adding these features to your Views 3 submodule. I'm currently not using Views 3 on any site but decided to give it a try along with your infinite_scroll module. I've tested the latest build of infinite_scroll and here are my results:
- The manual/automatic setting seems to have no effect. All views with infinite pager are set to manual regardless of chosen setting.
- Clicking on the "More" link on a view setup with the infinite_scroll pager loads the new page overtop the previous much exactly like the normal Views pager. Just to let you know that this did not happen with the previous build of the module that you had on github prior to your recent changes.
I'd also like to thank everyone involved, including thebuckst0p. I can continue to test both a Views 2.0 and 3.0 submodule.
Comment #12
cerup commentedjerodfritz what are your thoughts on backporting this to views 2?
Like pribeh, I'm not sure using views 3 and won't be until it's in release (my site is already in production). I'm sure you'll get more testers by having a version for views 2.
Have you talked to thebuckst0p about coordinating efforts or are you going to work on this independently?
Comment #13
dropchew commentedsubscribing
Comment #14
jerodfritz commentedHey thebuckst0p,
I like your idea of separate branches for views 2 and views 3 and putting this on d.o, but I don't have a d.o cvs account.
Comment #15
thebuckst0p commentedHi, just an update: I've been swamped with work since Drupalcon, so I haven't had any time to write new code. If anyone wants to start adding UI integration to the module, I'm more than happy to commit patches and/or make them co-maintainers.
Re: getting a d.o. CVS account, it was fairly simple, albeit it took a few weeks to get approved. I really don't like CVS, as an aside; I'm great with SVN but CVS always confuses the hell out of me. So 2 branches sounds great but I could use some assistance implementing that. Any CVS experts here who could assist me for 15 minutes over IRC or AIM? (Otherwise I'll just go on IRC when I have some time and ask there.)
On a personal note, I'm in the process of transitioning from a full-time job to full-time freelance, which means the next week (like the last 3) I'm working 16 hour days, but I will make every effort to work on this in the next few days. Thanks for your patience everyone.
Comment #16
cerup commentedThanks for being upfront and honest thebuckst0p
I just wanted to check in and see if either you or jerodfritz have made any progress on either the views 3 or views 2 implementation (though I'm more interested in views 2).
jerodfritz , on your webpage, the link to the demo is missing the 'h' in 'http' so the link doesn't work. Also, would be nice to see an example of the manual (button) based implementation on the demo page as well as the auto one.
Comment #17
thebuckst0p commentedcerup, thanks for keeping on top of my status. I committed a bunch of new code just now. I neglected to include the JS file in the first commit, that's in now. I've also gotten the modified JS up to date with the latest clean Views JS, and added some other tweaks, see http://drupal.org/cvs?commit=365026.
I'd like to create a new dev release, but I get this error:
How do I get around that? Should I make a dev tag?
The module is currently minimally functional: enable it, create a page view that uses a pager, turn on 'ajax pager' and 'mini pager', and it will override the default mini pager with the infinite pager. That's better than before, but still needs the UI configuration.
Besides the learning curve of Views UI integration, there are a number of questions I'll need to figure out that I'll create their own issues for as I get to them. Two major ones so far: 1) how to make sure both 'Infinite Pager' (in the Pager list) and Ajax are both on (because it needs both to work; I'm hoping it'll be straightforward to do form validation for that; 2) how to override the JS without overriding the entire functions for all views and pagers on a given page (i.e. it needs to co-exist with the existing pagers).
Is there anyone with Views UI experience who could help me a little if I get stuck?
Comment #18
thebuckst0p commentedI'm renaming this issue from "Code is finished" to "Release plans" because neither jerodfritz nor I have fully finished code, and the title could be misleading to people visiting the issue queue.
Comment #19
thebuckst0p commentedjerodfritz, what's the status of your d.o. cvs account application?
Comment #20
cerup commentedThanks for the update thebuckst0p.
If I get a chance, I'll see if I can help at all, but I don't know really anything in terms of the views UI either.
I did get a change to try the latest CVS commit. It did replace the mini pager with 'more' but it didn't append the new page to the bottom and worked like a normal mini pager (replaced the previous page); so it didn't really work for me.
We'll have to see if there's a way to add a pager option too because I don't think we'd want to only have the option to override all mini pagers. I couldn't find a plugin option for views 2 like there is for views 3 though so I'm wondering if that's possible.
Comment #21
jerodfritz commentedI check a minute ago and they are awaiting a second confirmation from you to allow me to be the co-maintainer.
Comment #22
jerodfritz commentedI added the manual demo here http://demo.centogram.com/infinite-scroll-manual . The automatic loading can still be demo'd here http://demo.centogram.com/infinite-scroll .
Comment #23
pribeh commentedHi everyone,
Just checking back into this thread. I checked out jerodfritz' demo (Thanks for putting them up online for testing) of the two different modes (manual and automatic). Sorry if I'm confused here but isn't the point of the manual version of infinite scroll to function exactly like the automatic version? Perhaps this just hasn't been accomplished yet but the demo shows the manual version simply loading the next page in replacement of the previous. Maybe I'm missed something. Anyway, thanks so much again for your excellent work on this.
Best,
Thomas
Comment #24
thebuckst0p commentedI confirmed at http://drupal.org/node/780202#comment-2963926:
Comment #25
cerup commentedjerodfritz, as pribeh mentioned the automatic demo works, but the manual one is just replacing the text (like a normal views pager) rather than appending it to the bottom of the previous page (also pointed out in #11).
Comment #26
thebuckst0p commentedcerup, I have it running on my site benbuckman.net now. Clearing all the caches helped. I've got the latest versions of core and all modules, maybe you're using an older version of something?
I've been swamped again, and "real" work has to come before this, but the next step is to code some messy form_alters to modify the pager list and intercept. (I assume that's possible, and don't see any other way, given that the pagers are not "pluggable" in Views2).
Comment #27
cerup commentedThanks for the update thebuckst0p. I'll have try again and try clearing the views cache (maybe that was the issue). I'm limited though since I currently use mini pagers throughout my site.
I was thinking, since it seems you can't create a new pager type in views 2.0, maybe we can create a new display type (like feed, attachment, block, page). So that way we could still use mini_pager or full_pager for that matter, but it'll only apply to a new display type 'infinite page'/'infinite block'? I'm not sure if there's a better way, but I would imagine this would work because we can keep your code mostly and just add a if case to check if the display type is 'infinite page' or not. Any thoughts? Could probably just copy views_plugin_display_page.inc and views_plugin_display_block.inc and rename them views_plugin_display_infinitepage.inc/views_plugin_display_infiniteblock.inc.
If I get a chance i'll look into it.
Comment #28
harrick commentedSubscribing
Comment #29
kjv1611 commentedLooks like a cool project. One thing I noticed on the sample page listed in the first post (and maybe this doesn't matter), but the way this thing is working is that when it reaches the last node/content piece, it's still "auto-paging" past it, but instead, it just basically re-shows the last group of items again... If possible via some conditional code, I'd think it best if it saw when it reached the end, and then no longer "auto scrolled" past that..
Comment #30
kjv1611 commentedThis was the link I was referring to, by the way:
http://demo.centogram.com/infinite-scroll
Comment #31
Remon commentedsubscribe
Comment #32
freelylw commentedsubscribing., waiting for the release.....
Comment #33
vikom commentedSubscribe
Comment #34
mark. commentedIn the meantime for views2 users: http://drupal.org/project/endless_page
Comment #35
cerup commentedzywiec endless page only works with node views and is also an abandoned module.
Comment #36
mark. commentedFor someone that needs this functionality right now for Views2 (instead of nothing right now for Views2), here's a module that provides an endless page in node views that may or may not still be maintained (which doesn't matter anyways when the code works in the first place): http://drupal.org/project/endless_page
Personally, I would rather use an unmaintained, production-ready views add-on module, than an unstable alpha version of a module as all-encompassing as Views, just to use an unstable views add-on module that hasn't even released one dev version, not to mention alpha or beta.
Comment #37
cerup commentedzywiec, I'm sorry I didn't mean to make it sound like endless page isn't an option. I'm only making the note so other people are aware that endless page does not provide the full functionality that Views Infinite Pager is aiming to achieve (since endless page doesn't work with fields).
If people only need endless page for node views, I'm sure endless page will be a good option for them. The fact that it is abandoned will be important when it comes to bugs, updates, and future movement from drupal 6 to drupal 7. If that is not a concern, there's no reason not to try it out :D
Comment #38
meatbag commentedsubscribing
Comment #39
YK85 commentedsubscribing
Comment #40
YK85 commentedHi, I was wondering if there is any timeline before a release of Views Infinite Pager? Thanks!
Comment #41
cerup commentedPlease check the new issue and test/review. #875334: Stable release. Please review.
Comment #42
chuckbar77 commentedsubscribe
Comment #43
cerup commentedI've committed and made a 'first' release. It'll be up to download in about 10 minutes.
I'm marking this as fixed. If you have new bugs/issues, please create a new issue for them.