The module I plan on maintaining is a very simple module I have created called IP Check. This modules job is to look at a users ip address and determine whether this user is coming to the site from the internet or from our internal network. This module takes the users IP address, converts it to a long using the ip2long() function and then checks to see if the converted ip address is a class a, b, or c address (http://en.wikipedia.org/wiki/Private_network). If the user is NOT using one of these addresses the IP Check module will then redirect the user to "/user/login" until they are authenticated. If they are using a class a, b, or c address then the site will load as usual and the IP Check module will do nothing.
There are two modules I have found that do similar things but neither do specifically what I needed them to do.
http://drupal.org/project/ipAuthenticator
http://drupal.org/project/ip_login
The IP Authenticator module assigns users to a role, I have found this is not what I needed because I still want the user to be able to login to the site if they are inside the network. Furthermore I could not find a way to define all public IP addresses within the settings of IP Authenticator.
The IP Login module for me has the same issue. It automatically logs users on by assigning them to a role and the login block is not displayed on the main page.
Hopefully this sheds some light on my issue and I believe this module is if anything a faster way for developers expert or novice to implement this function quickly and simply. I hope to add functionality to this module as I become more experienced with Drupal and PHP. I also believe this could be a great learning experience and should help keep me motivated
to learn more.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | ipcheck.zip | 7.69 KB | jhus |
Comments
Comment #1
jhus commentedComment #2
jhus commentedComment #3
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.
As there are already two projects with a similar purpose, why didn't you open feature requests for the features you think missing in them?
Comment #4
avpadernoComment #5
jhus commentedbump
Comment #6
avpadernoSee comment #3.
Comment #7
jhus commentedI did not think to. I had opened an issue asking if IP Authenticator had the features I was looking for but I never got an answer so I decided to write up this module.
Comment #8
avpadernoMay you report the link to the report you opened in the project queue?
Comment #9
jhus commentedYup, here it is. Waited 12 days and did not get a single response so I decided to go ahead and write my own code.
http://drupal.org/node/760616
Comment #10
jhus commentedbump
Comment #11
avpadernoThe issue you open is a support request, but you didn't report a patch to add the features you wanted to see added in the existing project, which is what we mean by joining forces.
Comment #12
jhus commentedIll get with the ipAuthenticator maintainers, thanks!
Comment #13
qasimzee commented@kiamlaluno: I think now the status can be changed to wontfix, right?
Comment #14
avpadernoConsidering what I reported in my previous comment, I think that this application can be marked as as it doesn't follow the requirements reported in the specific page. I will keep it open for some days to see if it becomes a different type of CVS application.
Comment #15
jhus commentedThe requirements you are referring would be requesting a patch for the ipAuthentiactor module, correct?
Comment #16
avpadernoThe requirements page states that the proposed module must not duplicate the work done in existing projects (which doesn't mean duplicate code); this means that you should join forces with the maintainer of the existing module.
Comment #17
jhus commentedWhat if the current maintainers refuse to use or implement some form of my code? Or even different code that achieves the same goal?
Comment #18
qasimzee commentedIt depends on maintainers but most of the maintainers welcome your work. If you feel that the functionality will be a good addition to the existing module, write complete detail in the issue queue of that project.
Also upload some sample patch so that maintainers can see your seriousness about the project.
Comment #19
jhus commentedAlright, I did some more digging and found that the maintainers of the ipAuth module are not very active on the site anymore.
http://drupal.org/user/274645/track
Has not made a post since July 2, 2009.
http://drupal.org/user/59025/track
Looks about the same for the second maintainer.
From what Ive seen they have not made any posts in quite some time in the issue queue either. Am I just SOL?
Comment #20
qasimzee commentedCheck this if you think the module is abandoned
http://drupal.org/node/251466
Comment #21
avpadernoIf you think the module is abandoned, and you want to take it over, then open an issue report as reported in http://drupal.org/node/251466; once you move the support request to the Drupal.org site webmasters queue, add a note about you not having a CVS account, and a link to this application report.
Comment #22
avpadernoPlease read the following links as this is very important information about CVS applications.
Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says: