After upgrading ctools as follows, tabs stopped showing completely, and the "tabs" style does not exist anymore.

 description = A library of helpful tools by Merlin of Chaos.
 core = 6.x
 package = Chaos tool suite
-; Information added by drupal.org packaging script on 2010-02-27
+; Information added by drupal.org packaging script on 2010-04-15
 version = "6.x-1.x-dev"
 core = "6.x"
 project = "ctools"
-datestamp = "1267229039"
+datestamp = "1271289877"

And the changelog that was added is:

+#726320 by gordon: Allow the CTools wizard to have query strings in the wizard path.
+#711664 by meclimdul: Make the 'hook' version of plugins now optional and improve code around it.
+#745468 by alevine and Scott Reynolds: Make ajax better able to know what .js/.css was already on the page.
+#722246: Search tabs not quite right, particularly with retaining keywords across tabs. This mostly fixes.
+#709754 followup by yhahn: Improved documentation for export.inc
+#565808 by cha0s, zroger and davereid: Backport nojs handling from D7.
+#704132 by killes: Allow access/selection rule based on whether taxonomy term has a parent.
+#747588 by mikeker: Add taxonomy description to context tokens.
+#741588 by Jody Lynn: add db_rewrite_sql() to comments pane query to match core.
+#531366 by mikeker: Move token substitutions to prior to filtering in custom content type. This could have some effects on existing installs.
+#718028 by redben: Improved documentation for wizard.inc
+#750004 by jhedstrom: Comment pane ignores node comment display setting.
+#752960 by mgriego: Redirect destination on 'delete' in admin links could be wrong.
+#754234 by killes: Node form content types not showing up due to logic error.
+#754594 by lavamind: Add a "book children" content type.

So one of this commits broke it. I cannot bisect ctools at the moment, but I hope it helps.

CommentFileSizeAuthor
#39 panels_tabs.zip10.83 KBdvasquez
#23 panels_tabs.zip10.7 KBdvasquez
#15 panels_tabs_784538.patch8.05 KBcrea
#13 panels_tabs-784538-13.patch6.44 KBtauno

Comments

yhager’s picture

yhager commented

Just by reading the commit messages, I would check first

+#711664 by meclimdul: Make the 'hook' version of plugins now optional and improve code around it.
locomo’s picture

locomo commented

confirming this too .. tabs are lost with latest ctools dev release

zuzu83’s picture

zuzu83 commented

confirming :(

ehudash’s picture

ehudash commented

subscribing

jthomasbailey’s picture

jthomasbailey commented

subcribing

freelylw’s picture

freelylw commented

same here

chowdah’s picture

chowdah commented

Mine didn't disappear, they never showed up because the ctools I had in place was the latest dev when I installed this module and tabs. When I downgraded the ctoolsto the latest stable version (6.x-1.3), 'tabs' appeared fine. I'll post an issue in the ctools module...

chowdah’s picture

chowdah commented
jthomasbailey’s picture

jthomasbailey commented
Priority: critical » really, really critical
fugazi’s picture

fugazi commented

subcribing

bennos’s picture

bennos commented

there is a new submodule panely styles, where we can create region styles and panel style with color, fonts and borders.
Look like there are a lot of changes to get the panels styles complete.
panels style looks great, but makes me unhappy about panels tabs does not work anymore.

Hopefully we can plug in to the new style submodule.

bennos’s picture

bennos commented

just looked in the code of the panels style submodule.

looks like, panel tabs could plugin there.
Folder:
panels/panels_stylizer/plugins

some code change are needed. Currently I have no time, to look deeper or to write a patch or just the style.

tauno’s picture

tauno commented
Status: Active » Needs review
StatusFileSize
new panels_tabs-784538-13.patch6.44 KB

Updating it to use the ctools method of including plugins instead of a panels specific hook seems to be working (http://manueg.okkernoot.net/blog/200910/how-create-panels-style-plugin)

kompressaur’s picture

kompressaur commented

subscribing

crea’s picture

crea commented
StatusFileSize
new panels_tabs_784538.patch8.05 KB

Better patch with "modern" plugin declaration.

bennos’s picture

bennos commented

thx for the patch. wil try it on a dev page.

jthomasbailey’s picture

jthomasbailey commented

Just tried #15 with the newest Panels (2010-May-20) and Ctools (2010-May-20) devs: Panels Tabs option still does not show up in Panels or Mini Panels. No errors, just didn't appear.

EDIT: Redownloaded Panels Tabs and tried #13 for the heck of it, got:


panels_tabs J$ patch < panels_tabs.patch
(Stripping trailing CRs from patch.)
patching file panels_tabs.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file panels_tabs.info.rej
(Stripping trailing CRs from patch.)
patching file panels_tabs.module
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file panels_tabs.module.rej
(Stripping trailing CRs from patch.)
patching file tabs.inc

Didn't work.

fugazi’s picture

fugazi commented

@hobgobbler cache emptied? works for me

jthomasbailey’s picture

jthomasbailey commented

@fugazi yeah, I just flushed all caches and tried #15, still nothing. Weird.

ianchan’s picture

ianchan commented

Tabs working again using:

Panels 6.3.4
Ctools 6.1.4
Panel_tabs 6.1.x-dev + patch from #15

Didn't work until after clearing cache

ALSO, the patch didn't work until I manually copied tabs.inc using 

 cp tabs.inc ../panels/plugins/styles/

Probably due to the way I applied the patch?

jthomasbailey’s picture

jthomasbailey commented

That did it: I had to copy tabs.inc to panels/plugins/styles. thanks ianchan

dvasquez’s picture

dvasquez commented

Works for me!! Thanks men!!
Bless!

dvasquez’s picture

dvasquez commented
StatusFileSize
new panels_tabs.zip10.7 KB

Here is the module, it's working for me!

crea’s picture

crea commented

You need most recent dev version of the Tabs Panels Style module to apply my patch in #15.

dvasquez’s picture

dvasquez commented

Thanks my friend!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

I'm sorry i didn't saw the issue.

I fixed it with nearl the same patch. I released also the first beta of panels tabs.
Thanks for helping on the issue.

Draven_Caine’s picture

Draven_Caine commented
Version: 6.x-1.x-dev » 6.x-1.0-beta1
Status: Fixed » Active

This is still an issue for panels 3.4.
I changed it back to active since the beta 1 of panels tabs style doesnt work for panels 3.4.

Panels tabs style.dev isnt fix this issue either.

dawehner’s picture

dawehner
Primary language German
commented

You have to clear the cache to make it working.

Draven_Caine’s picture

Draven_Caine commented

My cached was cleared.
I use this module a bit deeper than most people.

  • Panels
  • Panels Everywhere
  • Tinsel

    • If you don't upgrade panels and ctools than everything is fine but as the release notes on the 6.x-1.0-beta-1 version says, its updated to work with panels 3.3 But the new panels is 3.4 so the problem isn't fixed from the beta version.

    stg11’s picture

    stg11 commented

    beta1 not working for me either with Panels 3.4

    fugazi’s picture

    fugazi commented

    6.x-1.0-beta-1 works for me is not even any tabs. use panles 4.3. #15 works. Sorry for my bad english

    butler360’s picture

    butler360 commented

    Beta1 doesn't work with 3.4 for me, either.

    crea’s picture

    crea commented

    plugins directory is empty in beta
    http://drupalcode.org/viewvc/drupal/contributions/modules/panels_tabs/pl...

    kompressaur’s picture

    kompressaur commented

    tried the module in #23 but not working for me

    jdidelet’s picture

    jdidelet commented

    subscribing

    jthomasbailey’s picture

    jthomasbailey commented

    Make a copy of tabs.inc and move it to panels/plugins/styles.

    fabianx’s picture

    fabianx commented

    Seems maintainer forgot to add the new file.

    Moving works, but you can also leave tabs.inc into panels_tabs/plugins/styles.

    Note that only styles/ did not work for me with Panels 3.4.

    Best Wishes,

    Fabian

    butler360’s picture

    butler360 commented

    Seems to work with 3.4 if you download the zip from #23, upload the styles directory to the current panels_tabs directory, and then run cp tabs.inc ../../panels/plugins/styles from the panels_tabs/styles directory.

    dvasquez’s picture

    dvasquez commented
    StatusFileSize
    new panels_tabs.zip10.83 KB

    This is comming from #23.
    Now it's 6.x-1.0-beta1 (2010-May-22) adding tab.inc, i thisnk it can work adding tab.inc in panels_tabs/plugins/styles folder or panels_tabs/styles folder, test it your self, please.

    jdidelet’s picture

    jdidelet commented

    #38 -> I confirm, it's working.

    dawehner’s picture

    dawehner
    Primary language German
    commented

    I forgot the tabs.inc file.

    Could you all try out the latest beta2?

    butler360’s picture

    butler360 commented

    I'm getting this after beta2:

    Fatal error: require_once() [function.require]: Failed opening required './sites/all/modules/panels_tabs/plugins/styles/tabs.inc' (include_path='.:/usr/share/php:/usr/share/pear') in /var/aegir/platforms/drupal-6.16/sites/all/modules/ctools/includes/plugins.inc on line 297
    dawehner’s picture

    dawehner
    Primary language German
    commented
    Version: 6.x-1.0-beta1 » 6.x-1.0-beta2

    Can you have a look whether the file is there? On you page. It's now included into the beta2.

    butler360’s picture

    butler360 commented

    After getting the files in order I now get:

    Fatal error: Cannot redeclare theme_panels_tabs_style_render_panel() (previously declared in /var/aegir/platforms/drupal-6.16/sites/all/modules/panels/plugins/styles/tabs.inc:30) in /var/aegir/platforms/drupal-6.16/sites/all/modules/panels_tabs/plugins/styles/tabs.inc on line 72

    EDIT: Seems like it's working now. I think things got messed up because I made those manual changes I described above. Then when I updated to beta2 I basically got locked out of the site with those WSODs, so I couldn't clear any caches (drush would give up, too, when it tried to clear the cache and encountered those errors).

    dawehner’s picture

    dawehner
    Primary language German
    commented
    Status: Active » Postponed (maintainer needs more info)

    How did you updated your module?
    Please redownload the file again. There is not the same function twice.

    butler360’s picture

    butler360 commented
    Status: Postponed (maintainer needs more info) » Active

    Like I said above, it's working now.

    Thanks!

    dawehner’s picture

    dawehner
    Primary language German
    commented
    Status: Active » Fixed

    Ah ok.

    So this is fixed now.

    Fanaile’s picture

    Fanaile commented

    I'm getting the same error as described in #44

    Fatal error: Cannot redeclare theme_panels_tabs_style_render_panel() (previously declared in /mnt/w0609/d17/s48/b0313c32/www/thelandlordpages.com/sites/all/modules/panels/plugins/styles/tabs.inc:30) in /mnt/w0609/d17/s48/b0313c32/www/thelandlordpages.com/sites/all/modules/panels_tabs/plugins/styles/tabs.inc on line 72

    How did the error clear? Is it something I just have to wait for it to finish jumbling whatever it's doing.

    The site was working; the last thing I tried to do before I received this error was I installed a new version of Location and ran update.php. Then when everything ran and I clicked on the link to go to the administration page, this error came up?

    butler360’s picture

    butler360 commented

    Make sure you removed the previous version's files and you have the latest version. Then clear all of your caches (Drupal, APC, cacherouter, boost). My problem seemed to be caused by me having a mix of beta and dev files.

    Fanaile’s picture

    Fanaile commented

    That worked, thanks!

    bennos’s picture

    bennos commented

    new version of ctools 1.6 and panels 3.5 and tabs are lost again.

    I have opened a new issue.
    http://drupal.org/node/813462

    Status: Fixed » Closed (fixed)

    Automatically closed -- issue fixed for 2 weeks with no activity.