Active
Project:
Boost
Version:
6.x-1.x-dev
Component:
Views
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Apr 2010 at 22:29 UTC
Updated:
20 May 2011 at 02:01 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mikeytown2 commentedcurrent hard-coded way to not count nodes in a view block.
Comment #2
mikeytown2 commentedComment #3
sillygwailoAttached is a patch for configuring which views get excluded from {boost_cache_relationships} in admin/settings/performance/boost (against DRUPAL-6--1-18). Is that sort of what you were going for?
Comment #4
mikeytown2 commentedLooking at the code, looks like its the right idea. Nice find with views_get_all_views(). I'll have in incorporate that into the code elsewhere.
I would like to do this one more level of granularity; being able to select which displays get used in the view. The original patch excludes all block displays which is surprisingly effective. Something along this with blocks excluded as the default sounds like the correct way to go about this.
Thanks for the patch BTW. I'll play with it in a couple of days.
Comment #5
sillygwailoThe attached patch allows the administrator to configure individual displays for exclusion from {boost_cache_relationships}. Maybe the form could use some work, including a button that selects all displays in a view?
Again, this patch applies to DRUPAL-6--1--18.
Comment #6
mikeytown2 commentedprototype code. Show views that have a path, can be cached by boost & anonymous users can access
Comment #7
mikeytown2 commentedGame plan:
Use the above code as the default set of views that will get searched. If the view takes an argument in the path, it will not be run when searching for the new/changed node in a view. In the long run I need to save the arguments the view takes otherwise bad things (performance wise) happen to your taxonomy/term/% view. Another idea is to search the boost_cache for the list of arguments in use; this won't have 100% coverage of new things though.
When new views get added; operate one of two ways:
A.) run it through the default code
B.) disable until admin has enabled it
List of views takes about a second to generate for me; thus I will save the views & ID's to use in the variables table. If option A is selected then it will update the list on cron. If option B then it only gets updated when the admin saves a new one.
Comment #8
mikeytown2 commentedvery untested patch; mainly been working on the UI.
Comment #9
mikeytown2 commentedthis patch has been tested more
Comment #10
mikeytown2 commentedSolving the taxonomy/term/% view issue is really only an issue if your using an external cache like varnish & your using the expire module. I would need to save all tids that I get from boost_expire_node() in a global so it will be available in the _boost_view_insert() shutdown function. Once there I pass the tid as an argument into the view; if I get a match, I then run that path
taxonomy/term/5through the url function to get the alias. I can then pass that along as a path that needs to be expired.Comment #11
mikeytown2 commentedRight now I'm making the assumption that your taxonomy term pages are filtered based off of domain access. This happens in the boost_expire_node function. If you ignore domain access for taxonomy/term then boost will not function correctly with the latest changes; it will not expire the correct taxonomy terms.
Quick hack is to load up the taxonomy/term/% view and see if it contains a domain access filter.
Complicated stuff...
Attached is the latest changes to the patch.
Comment #12
mikeytown2 commentedIncludes the quick hack
Comment #13
mikeytown2 commentedI think its safe to assume that if the node shows up on a view without the domain access filters, it will appear on all domains. Modified patch to take this into account.
Comment #14
mikeytown2 commentedcommitted.
Comment #15
Anonymous (not verified) commentedAfter updating to 28 Aug dev version, I'm now getting
when visiting certain pages as authenticated user. Am not using domain access module.
Comment #16
mikeytown2 commentedopps.
here's the patch to fix that; its been committed.
http://drupalcode.org/viewvc/drupal/contributions/modules/boost/boost.mo...
Comment #18
goldlilys commentedCan you please reupload the boost with the patch you created and link it here. The link on #16 is giving me a 404 page not found error.
Need this badly because mysql file size is growing too much that it takes forever to back it up.
Comment #19
ndstate commentedCan anyone verify which one of these patches will help with the table size?