Force domains to be lowercase when using batch/subdomain

I have yet to run the patch but what about the domains that are already in the database? We need some sort of check or update all to be lowercase; I have some uppercase domains currently in my database, it's how I found the bug. Will test later today.

Have you had any complaints about Domain Alias not working with i18n? I do know that in RFC 819 it says

The simple names that make up a domain may contain both upper and
lower case letters (as well as digits and hyphen), but these names
are not case sensitive.

When doing a query MySQL & case sensitive can cause odd results. Drupal will force the HTTP_HOST to lowercase

http://api.drupal.org/api/function/conf_init/6

function conf_init() {
...
  if (isset($_SERVER['HTTP_HOST'])) {
    // As HTTP_HOST is user input, ensure it only contains characters allowed
    // in hostnames. See RFC 952 (and RFC 2181).
    // $_SERVER['HTTP_HOST'] is lowercased here per specifications.
    $_SERVER['HTTP_HOST'] = strtolower($_SERVER['HTTP_HOST']);
    if (!drupal_valid_http_host($_SERVER['HTTP_HOST'])) {
      // HTTP_HOST is invalid, e.g. if containing slashes it may be an attack.
      header('HTTP/1.1 400 Bad Request');
      exit;
    }
  }
...

So IMHO you should force it to be lowercase since drupal does the same thing to HTTP_HOST

I don't run any i18n sites so I can't answer this question; but this is what I found on wikipedia.
http://en.wikipedia.org/wiki/Internationalized_domain_name#ToASCII_and_T...
http://en.wikipedia.org/wiki/Nameprep

Long story short, looks like it's lowercased.

hook_domain_validate_alter() - Cool!

update works.
admin/build/domain/batch/subdomain when entering in an uppercase domain, validation fails (good) but then all domains get set to red; making it hard to find which domain failed validation (bad).
Other then this interface formapi issue, looks good to me.

actually thinking about this... for utf8 i18n domains the regex will fail since you only allow [a-z0-9\.\-:]. The only safe way to test for uppercase IMHO would be a string comparison. Take the original string and see if it matches the mb_strtolower version. Something like this

if (strcmp($subdomain, mb_strtolower($subdomain, mb_detect_encoding($subdomain))) != 0) {
  // $subdomain contains uppercase letters
}

EDIT: you just might want to stick with strtolower since that is what core uses...
EDIT2: and in this case strtolower is pointless since the regex will catch the uppercase characters.

This still will only allow domains with a-zA-Z
http://blog.icann.org/2010/05/idn-cctlds/
The game changed 2 days ago. Only works in safari from what I can tell.

i18n is a different issue. If #TREE can't be fixed then this is RTBC from my point of view.

I thought we wanted to remove the case-sensitivity?

Thats why you got rid of the i in the regex below.

   // Check for valid characters
-  $pattern = '/^[a-z0-9\.\-:]*$/i';
+  $pattern = '/^[a-z0-9\.\-:]*$/';

This will now throw an error if $subdomain contains an uppercase character. What I was talking about in #15 (see newly added EDIT2 remark) has to do with non ascii domains. Both versions of this regex will flag them (idn domains) as invalid, but on May 5th (use safari for link in blog) ICANN now allows non ascii domains. This (idn domains) is a different issue, one that Drupal does not currently address AFAIK.

Last patch I tested (#13) fixed the bug addressed in this issue. I can test #19 sometime next week; but if you tested the #TREE indicator and it works, then I think that patch is RTBC.

Thanks for getting this one out :)