To help solve #690120: Cannot reliably check node_access from inside hook_node_save() with node grants we should likely use D7's Queue API and whenever a link is flagged for updating (like when a node is added/changed), it should be put into a queue and done at the end of the page request (or during cron).

CommentFileSizeAuthor
#14 xmlsitemap-link_update_queue-786484-14.patch3 KBlnunesbr
#11 xmlsitemap-link-update-queue-delayed-changes-786484-11.patch2.76 KBnaveenvalecha
#4 delayed-node-sitemap-changes-using-link-update-queue-786484-4.patch2.7 KBnagba
#3 mast-module-changes-2021871-3.patch6.75 KBnagba

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Priority: Normal » Major
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

This is waiting on #892114: Application to co-maintain Drupal Queue (is Drupal Queue maintained?) so that some issues can be resolved in the drupal_queue module.

nagba’s picture

nagba commented
StatusFileSize
new mast-module-changes-2021871-3.patch6.75 KB

Initial code for the feature. No tests yet. Is this something you had in mind ?

nagba’s picture

nagba commented
StatusFileSize
new delayed-node-sitemap-changes-using-link-update-queue-786484-4.patch2.7 KB

*facepalm* managed to upload the wrong patch.

Leeteq’s picture

Leeteq commented
Issue summary: View changes

#892114: Application to co-maintain Drupal Queue (is Drupal Queue maintained?) was fixed 4 years ago.
Now we have an untested patch awaiting feedback.

Leeteq’s picture

Leeteq commented
Status: Active » Needs review

The last submitted patch, 3: mast-module-changes-2021871-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: delayed-node-sitemap-changes-using-link-update-queue-786484-4.patch, failed testing.

webservant316’s picture

webservant316 commented

the issue here https://www.drupal.org/node/708078 is waiting for this patch. any progress?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

The queing system has been added by #2417027: Use support for running rebuild via queues, now we just need to implement it everywhere.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review
StatusFileSize
new xmlsitemap-link-update-queue-delayed-changes-786484-11.patch2.76 KB

Straight reroll of #4

Status: Needs review » Needs work

The last submitted patch, 11: xmlsitemap-link-update-queue-delayed-changes-786484-11.patch, failed testing.

socialnicheguru’s picture

socialnicheguru commented

How does one test this?

lnunesbr’s picture

lnunesbr
Primary language Portuguese, Brazil
Location 🇧🇷 São Paulo, BR
commented
StatusFileSize
new xmlsitemap-link_update_queue-786484-14.patch3 KB

Making last patch compatible with 7.x-2.x-dev