The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Some changes in core which are described here http://drupal.org/node/64279#node-view and here http://drupal.org/node/64279#node-types caused image module not to work anymore with the latest HEAD version of drupal core.
My patch corrects this hook usages in image module
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | image_head_2.patch.txt | 5.05 KB | Rok Žlender |
| #8 | image_head_1.patch | 4.53 KB | drewish |
| #5 | image_head_0.patch.txt | 4.55 KB | Rok Žlender |
| #4 | image_head_0.patch | 4.53 KB | drewish |
| #1 | image_head.patch | 2.06 KB | drewish |
Comments
Comment #1
drewish commentedI updated Rok Žlender's patch to add a .info file and I reverted the node's description back to it's initial, shorter value.
Comment #2
drewish commented(a little more descriptive title)
Comment #3
drewish commentedincluded vhmauery's changes to the settings forms and t() strings from this issue
Comment #4
drewish commentedoh, and here's that patch
Comment #5
Rok Žlender commentedPatch looks good.
I fixed only one thing in image_view return $node statement is missing. After this I ran simpletest image tests and there were no failures.
Comment #6
drewish commentedGood catch Rok, I'd noticed something wasn't working quite right but hadn't had time to track it down yet.
Comment #7
drewish commentedhumm, i got an error that your patch was corrupted. i added the return statement to mine and fixed t() place holder.
i think we still need to do some work on the image_view() function. it's ouputting two copies of the body.
Comment #8
drewish commented(note to self, preview, then attach patch...)
Comment #9
Rok Žlender commentedThe problem with two body outputs was in theme_image_body function which appended $node->body even though node_prepare already takes care of outputing body. I think my patch fixes this and hope it works now.
I changed the way image.info was diffed it should work on any system now and I diffed from drupal root dir.
Comment #10
drewish commentedRok, your patch didn't include my t() change. Incase you didn't know now '%foo' => $foo is equivalent to '!foo' => theme('placeholder', $foo).
Comment #11
walkah commentedcommitted. thanks a lot Rok & drewish!
Comment #12
drewish commentedwalka, which patch did you commit? did you fix the t() placeholder problem?
Comment #13
(not verified) commented