I am using 6.x-1.x-dev latest version, based on OpenAtrium 1.0beta6 (which shouldn't be an issue, as support_ticket is a separate content type)
Permission "can subscribe other users to notifications" is also checked for authenticated users.
As logged in with a basic autenthicated user, I can only subscribe myself to notifications, not any other users. (whereas I can see all users list when I am logged as administrator).
Any clue of what's hapenning?
Thanks in advance for your help :)
Best regards
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | support-can_subscribe_others.patch | 1.57 KB | Wergles |
| #1 | support-can_subscribe_others.patch | 1.69 KB | rsevero |
Comments
Comment #1
rsevero commentedAs far as I can see this is a bug on current code.
Here is a patch that fixes this issue.
I made it against freshly updated code from CVS.
Please consider it for inclusion.
Comment #2
jeremy commentedThe issue I see with this patch is it only allows adding new subscribers -- it doesn't seem to handle removing subscribers.
Comment #3
jeremy commentedI'm unable to duplicate the original bug report. I created a user with the stated permission and he is able to subscribe other users to notifications. Please provide more information about your configuration. What permissions does this user have? How many other users have access to this client?
The above patch does not appear to be related to this original issue.
Comment #4
rsevero commented@#2: Yes, you are right. I found out this before sending the patch but as the permission that triggers this behaviour is called "can subscribe other users to notifications" without any mention to the eventual possiblity of unsubscribing I thought this fix was appropriate.
Thinking about this issue from another perspective, without this patch the "can subscribe other users to notifications" is doing nothing at all. With the above patch it allows users with this permission to subscribe other users. I see this move as a clear improvement.
It might be argued that an extra patch that allows users with this permission to also unsubscribe other users might be needed but I don't think this last question is reason to discard the presented patch.
@#3: In your test the subscription additions made by a user with "can subscribe other users to notifications" but without "administer support" got actually applied?
Strange because in my test, despite not presenting any errors the additions are silently discarded. And looking at the code at support_comment I can't see how it could be different.
Are you sure the user you used in your test had only the "can subscribe other users to notifications" permission and not the "administer support" one?
Comment #5
rsevero commentedUpdating to latest released version.
Comment #6
Wergles commentedI've regenerated the patch against 6.x-1.8 so it gets applied with no fuzz and no offset.
Cheers.
Comment #7
RobertPope commentedCould this be related to http://drupal.org/node/1418200 in version 7?
Comment #8
johne commentedDidn't quite work for me. When I first add a user to the subscribed field of an already existing ticket, an email DOES NOT go to that new user. The user name does seems to get saved and shows up when the page loads again in the subscribed field. If I add another comment to the ticket, the new user will get that email. But not the one when first adding the user.
Comment #9
purencool commented