Attached is a patch against HEAD for ping.module. The changes are an addition of some more default ping sites (rootblog, Yahoo!) and the ability to selectively turn on and off each of those. Also included a way to add freeform ping URLs in the three most used variants (ping, extended ping, rss).

Not done, yet, adaption of the help text and consistency checking for the URLs.

CommentFileSizeAuthor
ping.module.diff.txt9.21 KBjluster

Comments

walkah’s picture

walkah commented

setting status to 'patch'. would also comment that this patch seems to add a bit more than the similar one by jseng - http://drupal.org/project/comments/add/7949 . Not quite a duplicate...

dries’s picture

dries commented
  1. I believe the context-sensitive help text needs to be udpated too.
  2. You can probably use form_checkboxes (plural) here.
  3. Your code has tabs in them or has indentation wrong. I can fix that though.
jluster’s picture

jluster commented

I'll update the patch to form_checkboxes and change the help text and associated stuff today. As for the tabs/spaces, the file should be expandtabs at 2 spaces per tab and indentation of 2 spaces. There's a chance my cvs diff screws this up (using BBEdit's CVS diff), so let me redo it in vim and see if that does it.

dries’s picture

dries commented

No reaction. In the mean time, other/similar improvements found their way into the ping module.

Uwe Hermann’s picture

Uwe Hermann commented

Reopening. AFAIK you cannot activate/deactivate pings per site in CVS right now, which this patch seems to allow. See also http://drupal.org/node/11148.

jluster’s picture

jluster commented

Uh, Dries, I stopped working on it when you indicted that the other patch was more to your likings (to mine, too, so...). If there's still interest in having an extendable ping.module, I'll make one for HEAD, but last time I checked people were more comfortable with a small preset number of ping sites instead of the "enter your own" approach.

scriptnews’s picture

scriptnews commented

Hi

I am happy to have found this post, as I was quite frustrated that such a powerful tool like Drupal does not offer better handling of one of the most important communications feature: pinging and selection of pings.

Here is what I would love to see and use:

1) a way to enter and administrate a variety of ping adresses.

WHY ? Simply the world is getting bigger and more divers every day. Today, most stuff is done via Technorati and Ping-o-Matic, but they onwly handle a few of options.

Think about different languages, for example :-) There is no ping for french, spanish or german services - are there none or don:t we just know about them ;-(

2) For the different Ping services, I would love to have options, at least to activate or deactivate them at my needs or likings.

Maybe even to link certain services to taxonomy :-)

WHY ? Similar to above, not every Ping or Blog likes to receive messages about every topic.
A preview a more specialized Ping-World over a short term, as blogging for business seems on the rise.

3) A ping module should not depend on CRON but should be able to ping a time of post (so to inform about updates) AND should also offer an oprtion to RE-ping in case of important modifications to the original.

This issue may shurely produce discussion, as such an option might open doors to spammers, but none that could be solved on a different level.

So far, 1 cent about ping ...

In conclusion, the ping module well could deserve more attention and I for shure would appreciate much a further development as described above.

Best regards

Roland
ScriptNews
Centroamerica.TV
http://centroamerica.tv/

ricabrantes’s picture

ricabrantes commented
Version: x.y.z » 7.x-dev
Status: Active » Closed (fixed)

bump

ricabrantes’s picture

ricabrantes commented
Status: Closed (fixed) » Active
Susurrus’s picture

Susurrus commented

Ping module is no longer a part of core as changed in this issue: #231437: Remove ping module from core. Multiping seems like it will be replacing the functionality of the ping module.

lilou’s picture

lilou commented
Status: Active » Closed (fixed)