The Taxonomy term processor will not produce an errors or warnings if the vocabulary is set to 'Select a vocabulary' and will proceed even to the point of importing nodes but just continuing to report 0% status. While this isn't a catastrophic bug, it's something that makes a certain bad configuration a bit harder to detect.

CommentFileSizeAuthor
#3 795114-4_validate.patch1.28 KBalex_b
#1 vocabularyvalidation.patch519 bytesbudda

Comments

budda’s picture

budda
Primary language English
Location Cheshire
commented
Status: Active » Needs review
StatusFileSize
new vocabularyvalidation.patch519 bytes

Added a validation method for the vocabulary.

AntiNSA’s picture

AntiNSA commented

subscribe

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 795114-4_validate.patch1.28 KB

This looks good, I added a check for a vocabulary when actually importing, too:

    if (!$vocabulary = $this->vocabulary()) {
      throw new Exception(t('No vocabulary specified for term processor.'));
    }
alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

Committed, thank you:

http://drupal.org/cvs?commit=419672

budda’s picture

budda
Primary language English
Location Cheshire
commented
Priority: Normal » Minor

Should error messages end in a fullstop? Not sure on the standard for that.

form_set_error('vocabulary', t('Choose a vocabulary'));

alex_b’s picture

alex_b commented
Status: Fixed » Active

I *think* they shouldn't. Needs fixing.

alex_b’s picture

alex_b commented
Status: Active » Reviewed & tested by the community

Let me set this to RTBC - that works as a note to self to commit this fix.

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

The message is fixed now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.